Bug 126052 - Avoid checking adjacent rules when doing a Force recalc or if no children changed
Summary: Avoid checking adjacent rules when doing a Force recalc or if no children cha...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-12-19 21:55 PST by Ryosuke Niwa
Modified: 2013-12-19 22:15 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-12-19 21:55:26 PST 
Consider merging https://chromium.googlesource.com/chromium/blink/+/2e53720ae89d22d963aae65fe2de1d4d82cbf3c2

Iterating the children is a waste if we're already going to recalc
everyone like in a Force situation or if we know that no children
needStyleRecalc(). We should skip all the checking in these cases.

I also refactored the loop into checkForChildrenAdjacentRuleChanges()
since recalcChildStyle was getting too long.