Bug 126042 - Clarify the behavior of composited canvases
Summary: Clarify the behavior of composited canvases
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
: 126039 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-12-19 19:17 PST by Simon Fraser (smfr)
Modified: 2013-12-19 21:29 PST (History)
9 users (show)

See Also:

Attachments
Patch (6.44 KB, patch)
2013-12-19 19:20 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (6.37 KB, patch)
2013-12-19 19:34 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (6.68 KB, patch)
2013-12-19 19:37 PST, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-12-19 19:17:00 PST 
Clarify the behavior of composited canvases
Comment 1 Simon Fraser (smfr) 2013-12-19 19:20:12 PST 
Created attachment 219718 [details]
Patch
Comment 2 EFL EWS Bot 2013-12-19 19:26:20 PST 
Comment on attachment 219718 [details]
Patch

Attachment 219718 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/50208140
Comment 3 Tim Horton 2013-12-19 19:30:11 PST 
Comment on attachment 219718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219718&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:88
>  #if ENABLE(WEBGL) || ENABLE(ACCELERATED_2D_CANVAS)

This #if needs to have a case for IOSurface-backed canvas too, otherwise if PLATFORM(MAC) were to compile WebGL out we'd always be returning UnacceleratedCanvas.

Or like you mentioned on IRC you might not need them at all.
Comment 4 Simon Fraser (smfr) 2013-12-19 19:34:51 PST 
Created attachment 219719 [details]
Patch
Comment 5 Simon Fraser (smfr) 2013-12-19 19:37:06 PST 
Created attachment 219720 [details]
Patch
Comment 6 Simon Fraser (smfr) 2013-12-19 19:38:06 PST 
*** Bug 126039 has been marked as a duplicate of this bug. ***
Comment 7 Simon Fraser (smfr) 2013-12-19 19:45:25 PST 
https://trac.webkit.org/r160894
Comment 8 Tim Horton 2013-12-19 21:29:34 PST 
Should HTMLCanvasElement::paintsIntoCanvasBuffer() reference this for clarity's sake?