WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
126042
Clarify the behavior of composited canvases
https://bugs.webkit.org/show_bug.cgi?id=126042
Summary
Clarify the behavior of composited canvases
Simon Fraser (smfr)
Reported
2013-12-19 19:17:00 PST
Clarify the behavior of composited canvases
Attachments
Patch
(6.44 KB, patch)
2013-12-19 19:20 PST
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Patch
(6.37 KB, patch)
2013-12-19 19:34 PST
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Patch
(6.68 KB, patch)
2013-12-19 19:37 PST
,
Simon Fraser (smfr)
thorton
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2013-12-19 19:20:12 PST
Created
attachment 219718
[details]
Patch
EFL EWS Bot
Comment 2
2013-12-19 19:26:20 PST
Comment on
attachment 219718
[details]
Patch
Attachment 219718
[details]
did not pass efl-ews (efl): Output:
http://webkit-queues.appspot.com/results/50208140
Tim Horton
Comment 3
2013-12-19 19:30:11 PST
Comment on
attachment 219718
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=219718&action=review
> Source/WebCore/rendering/RenderLayerBacking.cpp:88 > #if ENABLE(WEBGL) || ENABLE(ACCELERATED_2D_CANVAS)
This #if needs to have a case for IOSurface-backed canvas too, otherwise if PLATFORM(MAC) were to compile WebGL out we'd always be returning UnacceleratedCanvas. Or like you mentioned on IRC you might not need them at all.
Simon Fraser (smfr)
Comment 4
2013-12-19 19:34:51 PST
Created
attachment 219719
[details]
Patch
Simon Fraser (smfr)
Comment 5
2013-12-19 19:37:06 PST
Created
attachment 219720
[details]
Patch
Simon Fraser (smfr)
Comment 6
2013-12-19 19:38:06 PST
***
Bug 126039
has been marked as a duplicate of this bug. ***
Simon Fraser (smfr)
Comment 7
2013-12-19 19:45:25 PST
https://trac.webkit.org/r160894
Tim Horton
Comment 8
2013-12-19 21:29:34 PST
Should HTMLCanvasElement::paintsIntoCanvasBuffer() reference this for clarity's sake?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug