RESOLVED FIXED 126036
CStack: The JIT does not need a slow path stack check 
https://bugs.webkit.org/show_bug.cgi?id=126036
Summary CStack: The JIT does not need a slow path stack check
Mark Lam
Reported 2013-12-19 18:19:51 PST
The JIT uses the C stack which is not growable. Hence, by the time we get to the operationStackCheck() helper, a stack overflow is imminent. Redoing the stack check there will achieve nothing. Hence, we'll rename operationStackCheck() to operationThrowStackOverflowError(), and change the JIT code to reflect this reality that a StackOverflowError will be thrown unconditionally when we call this helper.
Attachments
the patch. (7.40 KB, patch)
2013-12-19 18:25 PST, Mark Lam 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2013-12-19 18:25:02 PST
Created attachment 219710 [details] the patch.
Geoffrey Garen
Comment 2 2013-12-19 18:31:17 PST
Comment on attachment 219710 [details] the patch. r=me Once we have a host zone reserved, we should just compare SP to addressOfJSStackLimit.
Mark Lam
Comment 3 2013-12-19 18:35:29 PST
Thanks for the review. Landed in r160890: <http://trac.webkit.org/r160890>.
Note You need to log in before you can comment on or make changes to this bug.