Bug 12602 - XPath functions string(), normalize-space() and string-length() don't work without arguments
Summary: XPath functions string(), normalize-space() and string-length() don't work wi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: XML (show other bugs)
Version: 420+
Hardware: Macintosh OS X 10.4
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks: 12584
  Show dependency treegraph
 
Reported: 2007-02-04 11:42 PST by Alexey Proskuryakov
Modified: 2007-02-04 22:16 PST (History)
0 users

See Also:


Attachments
proposed fix (4.69 KB, patch)
2007-02-04 11:59 PST, Alexey Proskuryakov
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2007-02-04 11:42:54 PST
This is another case of Value(bool) ctor being called unexpectedly. I'm really wondering if we should just remove it.
Comment 1 Alexey Proskuryakov 2007-02-04 11:59:45 PST
Created attachment 12922 [details]
proposed fix
Comment 2 Darin Adler 2007-02-04 18:10:29 PST
Comment on attachment 12922 [details]
proposed fix

Maybe we should nip this problem in the bud by getting rid of the Value constructor that takes a bool. Instead that one could be private and we could have a named constructor for making Value from a bool, like Value::fromBool().

r=me
Comment 3 Alexey Proskuryakov 2007-02-04 22:16:15 PST
Committed revision 19399.