Bug 126018 – Web Inspector: Uncaught Exception: NavigationSidebarPanel.js: ERROR: TypeError: undefined is not a function (evaluating 'representedObject.saveIdentityToCookie(candidateObjectCookie)')

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

SUMMARY:
file:///Volumes/Data/Build/Debug/WebInspectorUI.framework/Resources/NavigationSidebarPanel.js:582:51:JS ERROR: TypeError: undefined is not a function (evaluating 'representedObject.saveIdentityToCookie(candidateObjectCookie)')

STEPS TO REPRODUCE:
1. Open Inspector for <http://bogojoker.com>
2. Inspect the Inspector (I typically do by the Resources Sidebar)
  => Exception in console, inspector² is broken

[Joseph Pecoraro]

Seems like the issue crops up when the item I have selected in the Resources Navigation sidebar is a FolderTreeElement, like "Scripts".

[Joseph Pecoraro]

Yes.

All new WebInspector.FolderTreeElement's are passed a representedObject of null or undefined. Eventually in TreeElement, that becomes just an empty object:

    this.representedObject = (representedObject || {});

Which is what I'm seeing here.

[Joseph Pecoraro]

Created attachment 219685 [details]
[PATCH] Proposed Fix

[EFL EWS Bot]

Comment on attachment 219685 [details]
[PATCH] Proposed Fix

Attachment 219685 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/50568041

[Joseph Pecoraro]

Created attachment 219706 [details]
[PATCH] Proposed Fix

On IRC the feedback was we should still be resilient against a missing representedObject.saveIdentityToCookie. So I added the if check, and console.error warn if it didn't exist.

[WebKit Commit Bot]

Comment on attachment 219706 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 219706

Committed r160888: <http://trac.webkit.org/changeset/160888>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.