Bug 126015 - Enable video on WinCairo port
Summary: Enable video on WinCairo port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 8
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on: 126319
Blocks:
  Show dependency tree / graph
 
Reported: 2013-12-19 13:55 PST by Alex Christensen
Modified: 2014-01-03 09:34 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.75 KB, patch)
2013-12-19 13:55 PST, Alex Christensen 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-12-19 13:55:11 PST 
Let's enable video on the WinCairo port using GStreamer.  People who want to build WinCairo without requiring GStreamer can still do that by removing ENABLE_MEDIA_CONTROLS_SCRIPT, ENABLE_VIDEO_TRACK, and ENABLE_VIDEO (or basically undoing this patch).
Comment 1 Alex Christensen 2013-12-19 13:55:52 PST 
Created attachment 219680 [details]
Patch
Comment 2 Philippe Normand 2013-12-20 05:38:39 PST 
Comment on attachment 219680 [details]
Patch

I have no idea about the VS build system but can these options be disabled via build-webkit like in other ports?
Comment 3 Alex Christensen 2013-12-20 10:07:17 PST 
There is not.  This is as simple as I could make the enabling and disabling.  You could do a string replace on this file before building, but then there would be changes in WebKitLibraries.  It would be somewhat complicated to put these feature defines in WebKitBuild.  I think this is a good solution, unless someone can think of a better one.
Comment 4 Philippe Normand 2013-12-23 07:25:56 PST 
Ok then, I'll let Brent review this. Good work, it's nice to finally this land in trunk!
Comment 5 Alex Christensen 2013-12-30 18:44:28 PST 
How do I add the gstreamer binaries and development binaries as a dependency in http://www.webkit.org/building/tools.html ?  I'd like to do that before putting this in. Applewin requires QuickTime and wincairo requires gstreamer or reversing this patch.
Comment 6 Alex Christensen 2014-01-03 09:34:07 PST 
http://trac.webkit.org/changeset/161266