Bug 126010 - GPRInfo references should be protected with ENABLE(JIT)
Summary: GPRInfo references should be protected with ENABLE(JIT)
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-19 12:53 PST by Alex Christensen
Modified: 2013-12-19 15:01 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.14 KB, patch)
2013-12-19 12:55 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-12-19 12:53:16 PST 
http://trac.webkit.org/changeset/160796/trunk/Source/JavaScriptCore/runtime/VM.h broke the Win64 build.  Here's the fix.
Comment 1 Filip Pizlo 2013-12-19 12:54:17 PST 
I don't like adding more #if ENABLE(JIT)'s.  Can't you just create a dummy stub GPRInfo?
Comment 2 Alex Christensen 2013-12-19 12:55:56 PST 
Created attachment 219678 [details]
Patch
Comment 3 Alex Christensen 2013-12-19 12:57:07 PST 
(In reply to comment #1)
> I don't like adding more #if ENABLE(JIT)'s.  Can't you just create a dummy stub GPRInfo?
Should this array even be in VM.h?
Comment 4 Filip Pizlo 2013-12-19 13:04:59 PST 
(In reply to comment #3)
> (In reply to comment #1)
> > I don't like adding more #if ENABLE(JIT)'s.  Can't you just create a dummy stub GPRInfo?
> Should this array even be in VM.h?

No, it shouldn't.  I don't think we need it.
Comment 5 Mark Hahnenberg 2013-12-19 13:09:54 PST 
See bug 126012.
Comment 6 Alex Christensen 2013-12-19 13:50:48 PST 
I'll let you fix this in the other bug, then.