RESOLVED WONTFIX 126010
GPRInfo references should be protected with ENABLE(JIT) 
https://bugs.webkit.org/show_bug.cgi?id=126010
Summary GPRInfo references should be protected with ENABLE(JIT)
Alex Christensen
Reported 2013-12-19 12:53:16 PST
http://trac.webkit.org/changeset/160796/trunk/Source/JavaScriptCore/runtime/VM.h broke the Win64 build. Here's the fix.
Attachments
Patch (1.14 KB, patch)
2013-12-19 12:55 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-12-19 12:54:17 PST
I don't like adding more #if ENABLE(JIT)'s. Can't you just create a dummy stub GPRInfo?
Alex Christensen
Comment 2 2013-12-19 12:55:56 PST
Created attachment 219678 [details] Patch
Alex Christensen
Comment 3 2013-12-19 12:57:07 PST
(In reply to comment #1) > I don't like adding more #if ENABLE(JIT)'s. Can't you just create a dummy stub GPRInfo? Should this array even be in VM.h?
Filip Pizlo
Comment 4 2013-12-19 13:04:59 PST
(In reply to comment #3) > (In reply to comment #1) > > I don't like adding more #if ENABLE(JIT)'s. Can't you just create a dummy stub GPRInfo? > Should this array even be in VM.h? No, it shouldn't. I don't think we need it.
Mark Hahnenberg
Comment 5 2013-12-19 13:09:54 PST
See bug 126012.
Alex Christensen
Comment 6 2013-12-19 13:50:48 PST
I'll let you fix this in the other bug, then.
Note You need to log in before you can comment on or make changes to this bug.