Bug 126007 - Implement a red zone in the JSStack so that we can remove entryChecks.
Summary: Implement a red zone in the JSStack so that we can remove entryChecks.
Status: RESOLVED DUPLICATE of bug 126790
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 125928
  Show dependency tree / graph
 
Reported: 2013-12-19 12:10 PST by Mark Lam
Modified: 2014-01-13 17:10 PST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2013-12-19 12:10:08 PST 
Currently, VM entry points in Interpreter.cpp calls JSStack::entryCheck() ensure adequate capacity on the JSStack before re-entering the VM.  We can eliminate this if we implement allow for a red zone in the JSStack.
Comment 1 Geoffrey Garen 2013-12-19 15:01:23 PST 
Let's call this the "host zone", to distinguish from the OS-provided redzone, which is for leaf functions.
Comment 2 Mark Lam 2013-12-23 14:40:31 PST 
It's a bit difficult to get this right with the JSStack internal pointers sometime pointing to the top of stack and sometimes pointing past the end of the stack.  To make the code more sane to reason about, I will first fix https://bugs.webkit.org/show_bug.cgi?id=125849 before returning to this bug.
Comment 3 Mark Lam 2014-01-13 17:10:07 PST 
This was fixed in r161927: <http://trac.webkit.org/r161927> which was committed for https://bugs.webkit.org/show_bug.cgi?id=126790.

*** This bug has been marked as a duplicate of bug 126790 ***