Bug 126002 – [GTK] Some unit tests using web extensions fail when run alone

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Carlos Garcia Campos]

For example /webkit2/WebKitWebExtension/document-loaded-signal. The problem is that the page is created before the dbus connection has been established, and we are connecting to web-page-created signal once we have a valid dbus connection. We should connect to the signal before connecting to dbus and queue any request to emit a dbus signal until the connection is set. This also fixes the WebExtensions tests when using the network process because a new web process is launched for every test case.

[Carlos Garcia Campos]

Created attachment 219668 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Gustavo Noronha (kov)]

Comment on attachment 219668 [details]
Patch

Quite clean. You could drop the type from the constructor and infer it based on which constructor gets selected (no URL => document loaded, URL => uri changed), but I think I prefer the explicit one, it's more future proof too.

[Carlos Garcia Campos]

(In reply to comment #3)
> (From update of attachment 219668 [details])
> Quite clean. You could drop the type from the constructor and infer it based on which constructor gets selected (no URL => document loaded, URL => uri changed), but I think I prefer the explicit one, it's more future proof too.

Thanks for the review.

[Carlos Garcia Campos]

Committed r160904: <http://trac.webkit.org/changeset/160904>