RESOLVED FIXED 126001
tryAddEventListener uses local PassRefPtr<> 
https://bugs.webkit.org/show_bug.cgi?id=126001
Summary tryAddEventListener uses local PassRefPtr<>
Eric Carlson
Reported 2013-12-19 11:26:04 PST
r160679 added a second use of a PassRefPtr<EventListener> parameter.
Attachments
Proposed patch (1.38 KB, patch)
2013-12-19 11:34 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2013-12-19 11:34:21 PST
Created attachment 219666 [details] Proposed patch
Daniel Bates
Comment 2 2013-12-19 11:36:42 PST
Comment on attachment 219666 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=219666&action=review > Source/WebCore/ChangeLog:10 > + because it is sometimes used twice. Nit: This line begins with extraneous whitespace.
Daniel Bates
Comment 3 2013-12-19 11:37:22 PST
(In reply to comment #2) > (From update of attachment 219666 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=219666&action=review > > > Source/WebCore/ChangeLog:10 > > + because it is sometimes used twice. > > Nit: This line begins with extraneous whitespace. This is OK as-is. I take it you feel this improves the readability of the change log entry.
Eric Carlson
Comment 4 2013-12-19 11:39:53 PST
Committed r160849: https://trac.webkit.org/r160849
Note You need to log in before you can comment on or make changes to this bug.