RESOLVED FIXED 125993
[GTK] The fullscreen API should be enabled by default 
https://bugs.webkit.org/show_bug.cgi?id=125993
Summary [GTK] The fullscreen API should be enabled by default
Enrique Ocaña
Reported 2013-12-19 06:00:06 PST
The enable-fullscreen setting should be enabled by default in WebKitGTK+.
Attachments
Patch (4.00 KB, patch)
2013-12-19 06:11 PST, Enrique Ocaña 		no flags
DetailsFormatted DiffDiff
Patch (4.00 KB, patch)
2013-12-20 01:37 PST, Enrique Ocaña 		no flags
DetailsFormatted DiffDiff
Patch (4.63 KB, patch)
2013-12-20 05:14 PST, Enrique Ocaña 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Enrique Ocaña
Comment 1 2013-12-19 06:11:38 PST
Created attachment 219644 [details] Patch
WebKit Commit Bot
Comment 2 2013-12-19 06:14:17 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Enrique Ocaña
Comment 3 2013-12-20 01:37:22 PST
Created attachment 219741 [details] Patch
Enrique Ocaña
Comment 4 2013-12-20 01:38:10 PST
Rebased and corrected the changelog.
Gustavo Noronha (kov)
Comment 5 2013-12-20 03:35:36 PST
Comment on attachment 219741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219741&action=review It sounds good to me, have this been discussed with Carlos, Phillippe or Martin? =) > Source/WebKit/gtk/webkit/webkitwebsettings.cpp:834 > + _("Whether the Mozilla style API should be enabled."), Mozilla style? This should say the same thing as the other one, and have a Since of 2.4 I believe. Would be good to have the gtk-doc documentation header added here, I think. > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:907 > + _("Whether to enable the Javascriipt Fullscreen API"), Javascript has 2 i's here, let's fix that too =)
Philippe Normand
Comment 6 2013-12-20 04:44:00 PST
Comment on attachment 219741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219741&action=review I agree with enabling this setting by default, fwiw >> Source/WebKit/gtk/webkit/webkitwebsettings.cpp:834 >> + _("Whether the Mozilla style API should be enabled."), > > Mozilla style? This should say the same thing as the other one, and have a Since of 2.4 I believe. Would be good to have the gtk-doc documentation header added here, I think. It's actually an on-going effort at W3C nowadays. http://www.w3.org/TR/fullscreen/ Can you please update the strings accordingly?
Enrique Ocaña
Comment 7 2013-12-20 05:14:07 PST
Created attachment 219752 [details] Patch
Gustavo Noronha (kov)
Comment 8 2013-12-20 06:26:54 PST
Comment on attachment 219752 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219752&action=review > Source/WebKit/gtk/webkit/webkitwebsettings.cpp:836 > + * Whether to enable the Javascript Fullscreen API. The API > + * allows any HTML element to request fullscreen display. See also > + * the current draft of the spec: > + * http://www.w3.org/TR/fullscreen/ Nit: these lines could be longer.
WebKit Commit Bot
Comment 9 2013-12-20 06:55:21 PST
Comment on attachment 219752 [details] Patch Clearing flags on attachment: 219752 Committed r160909: <http://trac.webkit.org/changeset/160909>
WebKit Commit Bot
Comment 10 2013-12-20 06:55:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.