Bug 125985 - Test that text-decoration-skip: ink is the same as regular underlines if no descenders
Summary: Test that text-decoration-skip: ink is the same as regular underlines if no d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-19 00:29 PST by Myles C. Maxfield
Modified: 2013-12-19 15:21 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.91 KB, patch)
2013-12-19 00:31 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (2.87 KB, patch)
2013-12-19 14:56 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2013-12-19 00:29:58 PST 
Test that text-decoration-skip: ink is the same as regular underlines if no descenders
Comment 1 Myles C. Maxfield 2013-12-19 00:31:14 PST 
Created attachment 219630 [details]
Patch
Comment 2 Simon Fraser (smfr) 2013-12-19 14:54:35 PST 
Comment on attachment 219630 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219630&action=review

> LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-no-descenders-expected.html:1
> +<!DOCTYPE HTML>

Minor preference for <!DOCTYPE html>

> LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-no-descenders-expected.html:8
> +<div style="display: inline-block; -webkit-transform: scale(5); -webkit-transform-origin: left top; -webkit-text-decoration-line: underline">NO DESCENDERS</div>

Please use text-decoration: underline

> LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-no-descenders.html:8
> +<div style="display: inline-block; -webkit-text-decoration-skip: ink; -webkit-transform: scale(5); -webkit-transform-origin: left top; -webkit-text-decoration-line: underline">NO DESCENDERS</div>

Ditto.
Comment 3 Myles C. Maxfield 2013-12-19 14:56:20 PST 
Created attachment 219686 [details]
Patch
Comment 4 WebKit Commit Bot 2013-12-19 15:21:14 PST 
Comment on attachment 219686 [details]
Patch

Clearing flags on attachment: 219686

Committed r160865: <http://trac.webkit.org/changeset/160865>
Comment 5 WebKit Commit Bot 2013-12-19 15:21:16 PST 
All reviewed patches have been landed.  Closing bug.