Bug 125980 - CStack Branch: Remove "AndAlloc" from sizeAndAllocFrameForVarargs and friends
Summary: CStack Branch: Remove "AndAlloc" from sizeAndAllocFrameForVarargs and friends
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-18 22:34 PST by Michael Saboff
Modified: 2013-12-19 07:45 PST (History)
0 users

See Also:


Attachments
Patch (8.28 KB, patch)
2013-12-18 22:39 PST, Michael Saboff
no flags Details | Formatted Diff | Diff
Patch with right defect referenced in ChangeLog (8.28 KB, patch)
2013-12-18 22:50 PST, Michael Saboff
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2013-12-18 22:34:19 PST
The function sizeAndAllocFrameForVarargs really only sizes a call frame for a varArgs call.  It and the related functions should be renamed, removing "AndAllocate" from their names.
Comment 1 Michael Saboff 2013-12-18 22:39:42 PST
Created attachment 219617 [details]
Patch
Comment 2 Michael Saboff 2013-12-18 22:50:23 PST
Created attachment 219618 [details]
Patch with right defect referenced in ChangeLog
Comment 3 Mark Lam 2013-12-18 23:34:26 PST
Comment on attachment 219618 [details]
Patch with right defect referenced in ChangeLog

r=me
Comment 4 Michael Saboff 2013-12-19 07:45:29 PST
Committed r160831: <http://trac.webkit.org/changeset/160831>