RESOLVED FIXED 125972
Add an utility class to simplify generating function calls 
https://bugs.webkit.org/show_bug.cgi?id=125972
Summary Add an utility class to simplify generating function calls
Benjamin Poulain
Reported 2013-12-18 19:15:36 PST
Add an utility class to simplify generating function calls
Attachments
Patch (14.07 KB, patch)
2013-12-18 19:20 PST, Benjamin Poulain 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-12-18 19:20:29 PST
Created attachment 219604 [details] Patch
Geoffrey Garen
Comment 2 2013-12-18 21:54:27 PST
Comment on attachment 219604 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219604&action=review r=me > Source/WebCore/ChangeLog:13 > + the stack, do the call, restores the stack, and restore the registers. Should be "does the call". > Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:1148 > + void test32AndSetFlags(RegisterID reg, TrustedImm32 mask = TrustedImm32(-1)) Is there going to be a version of test32 that doesn't set flags? If not, then I would just call this "test32". > Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:1158 > + Jump branchOnFlags(ResultCondition cond) I would just call this "branch". > Source/WebCore/cssjit/FunctionCall.h:41 > + static const JSC::MacroAssembler::RegisterID firstArgument = JSC::X86Registers::edi; > + static const JSC::MacroAssembler::RegisterID returnRegister = JSC::X86Registers::eax; Please use the values defined in GPRInfo (argumentGPR0, returnValueGPR) instead of redefining them here.
Benjamin Poulain
Comment 3 2013-12-19 17:36:01 PST
Committed r160881: <http://trac.webkit.org/changeset/160881>
Note You need to log in before you can comment on or make changes to this bug.