Bug 125968 - CSS: Fall back to cache-less cascade when encountering explicitly inherited value.
Summary: CSS: Fall back to cache-less cascade when encountering explicitly inherited v...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-18 18:32 PST by Andreas Kling
Modified: 2013-12-18 19:10 PST (History)
7 users (show)

See Also:

Attachments
Patch (7.08 KB, patch)
2013-12-18 18:33 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Andreas Kling 2013-12-18 18:33:13 PST 
Created attachment 219600 [details]
Patch

Bit quick, bit dirty.
Comment 2 Antti Koivisto 2013-12-18 18:39:06 PST 
Comment on attachment 219600 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219600&action=review

> Source/WebCore/css/StyleResolver.cpp:4273
> +bool StyleResolver::CascadedProperties::addMatches(const MatchResult& matchResult, bool important, int startIndex, int endIndex, bool inheritedOnly)

Argument return might end up reading better.
Comment 3 WebKit Commit Bot 2013-12-18 19:10:00 PST 
Comment on attachment 219600 [details]
Patch

Clearing flags on attachment: 219600

Committed r160820: <http://trac.webkit.org/changeset/160820>
Comment 4 WebKit Commit Bot 2013-12-18 19:10:02 PST 
All reviewed patches have been landed.  Closing bug.