Bug 125967 – WebKit2 View Gestures: Move WebProcess-side geometry collection into its own class

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Tim Horton]

When smart magnification is implemented, we're going to need a bit more code in the WebProcess dealing with retrieving geometry of elements and such.

Move the message from UIProcess->WebProcess to grab the visible content rect out of the DrawingArea and into ViewGestureGeometryCollector (new names HAPPILY accepted). This class will grow in the future, but for now it's just the one simple message.

[Tim Horton]

Created attachment 219599 [details]
patch

[WebKit Commit Bot]

Attachment 219599 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/DerivedSources.make', u'Source/WebKit2/UIProcess/DrawingAreaProxy.h', u'Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h', u'Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm', u'Source/WebKit2/UIProcess/mac/ViewGestureController.cpp', u'Source/WebKit2/UIProcess/mac/ViewGestureController.h', u'Source/WebKit2/UIProcess/mac/ViewGestureController.messages.in', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/WebPage/DrawingArea.h', u'Source/WebKit2/WebProcess/WebPage/DrawingArea.messages.in', u'Source/WebKit2/WebProcess/WebPage/ViewGestureGeometryCollector.cpp', u'Source/WebKit2/WebProcess/WebPage/ViewGestureGeometryCollector.h', u'Source/WebKit2/WebProcess/WebPage/ViewGestureGeometryCollector.messages.in', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.h', u'Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h', u'Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm', '--commit-queue']" exit_code: 1
ERROR: Source/WebKit2/WebProcess/WebPage/ViewGestureGeometryCollector.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Comment on attachment 219599 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219599&action=review

> Source/WebKit2/ChangeLog:45
> +        it can be safely used from other member's constructors.

members' ?

> Source/WebKit2/WebProcess/WebPage/ViewGestureGeometryCollector.h:50
> +

Extra newline.

[Tim Horton]

http://trac.webkit.org/changeset/160818