Bug 125959 - [Cocoa] Allow the web process plug-in to intercept resource requests
Summary: [Cocoa] Allow the web process plug-in to intercept resource requests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-18 16:12 PST by mitz
Modified: 2017-03-25 19:22 PDT (History)
0 users

See Also:

Attachments
Add -webProcessPlugInBrowserContextController:frame:willSendRequest:redirectResponse: (5.25 KB, patch)
2013-12-18 16:17 PST, mitz 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2013-12-18 16:12:14 PST 
[Cocoa] Allow the web process plug-in to intercept resource requests
Comment 1 mitz 2013-12-18 16:17:03 PST 
Created attachment 219580 [details]
Add -webProcessPlugInBrowserContextController:frame:willSendRequest:redirectResponse:
Comment 2 Anders Carlsson 2013-12-18 16:34:44 PST 
Comment on attachment 219580 [details]
Add -webProcessPlugInBrowserContextController:frame:willSendRequest:redirectResponse:

View in context: https://bugs.webkit.org/attachment.cgi?id=219580&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:144
> +    if (loadDelegate) {
>          setUpPageLoaderClient(self, *_page);
> -    else
> +        setUpResourceLoadClient(self, *_page);

I'd use an early return here to get rid of the ugly one-liner inside the brace.
Comment 3 mitz 2017-03-25 19:22:40 PDT 
Committed <https://trac.webkit.org/r160809>.