I would like to make the final change to enable video on Windows just be adding #define ENABLE_VIDEO. I'll submit that patch and ask webkit-dev what they think. To do that, I need to remove the requirement for VIDEO_TRACK to require VIDEO. This patch prepares us for such a dramatic switch.
Created attachment 219582 [details] Patch
Created attachment 219583 [details] Patch
Comment on attachment 219583 [details] Patch This causes compile errors. There are a few places where VIDEO_TRACK assumes VIDEO
Oh yeah, and it's a terrible idea to not have VIDEO_TRACK require VIDEO. I'm going to do this, and make the final switch turning on video in FeatureDefinesCairo.props instead of FeatureDefines.h.
Created attachment 219619 [details] Patch
Unofficial r+ here, will ping Brent to give the final thumbs up
Comment on attachment 219619 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219619&action=review Please use the $(WebKit_Libraries) variable instead of the relative paths. > Source/WTF/WTF.vcxproj/WTFDebugWinCairo.props:9 > + <Import Project="..\..\..\WebKitLibraries\win\tools\vsprops\WinCairo.props" /> This should be "$(WebKit_Libraries)\tools\..." > Source/WTF/WTF.vcxproj/WTFReleaseWinCairo.props:9 > + <Import Project="..\..\..\WebKitLibraries\win\tools\vsprops\WinCairo.props" /> Ditto. > Source/WTF/wtf/Platform.h:908 > +#define WTF_USE_GLIB 1 :-(
Created attachment 219662 [details] Patch
Comment on attachment 219662 [details] Patch Clearing flags on attachment: 219662 Committed r160855: <http://trac.webkit.org/changeset/160855>
All reviewed patches have been landed. Closing bug.