Bug 125941 – Add Obj C API for injected bundle PageGroup class.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Yongjun Zhang]

Need an Obj C API for injected bundle PageGroup class, and a method to expose the page group object from WKWebProcessPlugInBrowsingContextController.

[Yongjun Zhang]

Created attachment 219562 [details]
Add Obj C API (WKWebProcessPlugInPageGroup) for injected bundle PageGroup class.

Comment on attachment 219562 [details]
Add Obj C API (WKWebProcessPlugInPageGroup) for injected bundle PageGroup class.

View in context: https://bugs.webkit.org/attachment.cgi?id=219562&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.mm:46
> +    WKStringRef string = toCopiedAPI(_bundlePageGroup->identifier());
> +    return [wrapper(*toImpl(string)) autorelease];

You should be able to just return _bundlePageGroup->identifier(), since WTF::String converts to an NSString *.

[Yongjun Zhang]

Created attachment 219566 [details]
Use _bundlePageGroup->identifier() directly, instead of going through WFStringRef wrapper.

Comment on attachment 219566 [details]
Use _bundlePageGroup->identifier() directly, instead of going through WFStringRef wrapper.

View in context: https://bugs.webkit.org/attachment.cgi?id=219566&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.h:35
> +- (NSString *)identifier;

This is probably better expressed as @property (readonly) NSString *identifier;

> Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.mm:34
> +#import "WKAPICast.h"
> +#import "WKNSString.h"
> +#import "WKRetainPtr.h"

Probably don’t need these anymore.

> Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h:47
> +@property(readonly) WKWebProcessPlugInFrame *mainFrame;
> +
> +@property(readonly) WKWebProcessPlugInPageGroup *pageGroup;

There needs to be a space before the (, even though some existing code is wrong.

[Yongjun Zhang]

Created attachment 219576 [details]
Fix style issue and address review comments before landing.

[WebKit Commit Bot]

Comment on attachment 219576 [details]
Fix style issue and address review comments before landing.

Clearing flags on attachment: 219576

Committed r160803: <http://trac.webkit.org/changeset/160803>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.