Bug 125936 - WTF fails to compile with gcc 4.8.2 and -Werror=array-bounds
Summary: WTF fails to compile with gcc 4.8.2 and -Werror=array-bounds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hugo Parente Lima
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-18 11:55 PST by Hugo Parente Lima
Modified: 2013-12-19 09:08 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.43 KB, patch)
2013-12-18 12:00 PST, Hugo Parente Lima 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hugo Parente Lima 2013-12-18 11:55:33 PST 
There's the error:

Source/WTF/wtf/dtoa/double-conversion.cc:597:26: error: array subscript is above array bounds [-Werror=array-bounds]

"buffer[buffer_pos] = '\0';"

Just because buffer_pos a int instead of an unsigned int.
Comment 1 Hugo Parente Lima 2013-12-18 12:00:05 PST 
Created attachment 219555 [details]
Patch
Comment 2 WebKit Commit Bot 2013-12-19 09:08:17 PST 
Comment on attachment 219555 [details]
Patch

Clearing flags on attachment: 219555

Committed r160834: <http://trac.webkit.org/changeset/160834>
Comment 3 WebKit Commit Bot 2013-12-19 09:08:22 PST 
All reviewed patches have been landed.  Closing bug.