Bug 125932 - CStack Branch: Exceptions in LLIntSlowPaths shouldn't pop call frame
Summary: CStack Branch: Exceptions in LLIntSlowPaths shouldn't pop call frame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-18 11:01 PST by Michael Saboff
Modified: 2013-12-18 11:43 PST (History)
0 users

See Also:


Attachments
Patch (1.60 KB, patch)
2013-12-18 11:23 PST, Michael Saboff
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2013-12-18 11:01:47 PST
The macro LLINT_CALL_RETURN() in LLIntSlowPaths.cpp is popping the call frame and returning that call frame to the caller.  llint_slow_path_handle_exception already unwinds the stack via a call to genericUnwind().
Comment 1 Michael Saboff 2013-12-18 11:23:58 PST
Created attachment 219552 [details]
Patch
Comment 2 Mark Lam 2013-12-18 11:41:33 PST
Comment on attachment 219552 [details]
Patch

r=me
Comment 3 Michael Saboff 2013-12-18 11:43:10 PST
Committed r160783: <http://trac.webkit.org/changeset/160783>