Bug 125931 - CStack Branch: getHostCallReturnValue shouldn't pop the callFrame
Summary: CStack Branch: getHostCallReturnValue shouldn't pop the callFrame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-18 10:52 PST by Michael Saboff
Modified: 2013-12-18 11:51 PST (History)
0 users

See Also:

Attachments
Patch (3.73 KB, patch)
2013-12-18 10:56 PST, Michael Saboff 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2013-12-18 10:52:23 PST 
Given that getHostCallReturnValue() is called after the return of a slow path function and that return will pop the callee frame, there is no need to pop the callee frame in getHostCallReturnValue.
Comment 1 Michael Saboff 2013-12-18 10:56:31 PST 
Created attachment 219549 [details]
Patch
Comment 2 Geoffrey Garen 2013-12-18 11:46:40 PST 
Comment on attachment 219549 [details]
Patch

r=me
Comment 3 Michael Saboff 2013-12-18 11:51:11 PST 
Committed r160784: <http://trac.webkit.org/changeset/160784>