Bug 125908 - Add a simple stack abstraction for x86_64
Summary: Add a simple stack abstraction for x86_64
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-17 19:50 PST by Benjamin Poulain
Modified: 2013-12-18 17:24 PST (History)
2 users (show)

See Also:

Attachments
Patch (14.19 KB, patch)
2013-12-17 20:54 PST, Benjamin Poulain 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-12-17 19:50:31 PST 
Add a simple stack abstraction for x86_64
Comment 1 Benjamin Poulain 2013-12-17 20:54:16 PST 
Created attachment 219503 [details]
Patch
Comment 2 Geoffrey Garen 2013-12-17 23:21:03 PST 
Comment on attachment 219503 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219503&action=review

r=me

> Source/JavaScriptCore/ChangeLog:11
> +        Add an explicit abstraction for the "lea" instruction. This is needed
> +        by the experimental JIT to have add and substract without changing the flags.

Why do we need to avoid changing flags before a call? Would be good to explain that.

> Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h:231
> +#if ENABLE(CSS_SELECTOR_JIT)

No need for the #if.

> Source/WebCore/cssjit/StackAllocator.h:112
> +    void combine(StackAllocator&& stackA, StackAllocator&& stackB)

I think the typical compiler word for this is "merge".
Comment 3 Benjamin Poulain 2013-12-18 17:24:26 PST 
Committed r160800: <http://trac.webkit.org/changeset/160800>