Bug 125904 - Do not create cue subtree just to delete it
Summary: Do not create cue subtree just to delete it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-17 18:41 PST by Eric Carlson
Modified: 2013-12-18 10:29 PST (History)
4 users (show)

See Also:


Attachments
Proposed patch (1.48 KB, patch)
2013-12-18 10:10 PST, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2013-12-17 18:41:39 PST
TextTrackCue creates its display lazily, so it might be NULL when removeDisplayTree or setActive(false) is called. Don't bother creating the display tree if we only want to delete it.
Comment 1 Eric Carlson 2013-12-18 10:10:51 PST
Created attachment 219543 [details]
Proposed patch
Comment 2 Jer Noble 2013-12-18 10:12:08 PST
Comment on attachment 219543 [details]
Proposed patch

r=me.
Comment 3 WebKit Commit Bot 2013-12-18 10:29:41 PST
Comment on attachment 219543 [details]
Proposed patch

Clearing flags on attachment: 219543

Committed r160777: <http://trac.webkit.org/changeset/160777>
Comment 4 WebKit Commit Bot 2013-12-18 10:29:43 PST
All reviewed patches have been landed.  Closing bug.