WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
125904
Do not create cue subtree just to delete it
https://bugs.webkit.org/show_bug.cgi?id=125904
Summary
Do not create cue subtree just to delete it
Eric Carlson
Reported
2013-12-17 18:41:39 PST
TextTrackCue creates its display lazily, so it might be NULL when removeDisplayTree or setActive(false) is called. Don't bother creating the display tree if we only want to delete it.
Attachments
Proposed patch
(1.48 KB, patch)
2013-12-18 10:10 PST
,
Eric Carlson
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Carlson
Comment 1
2013-12-18 10:10:51 PST
Created
attachment 219543
[details]
Proposed patch
Jer Noble
Comment 2
2013-12-18 10:12:08 PST
Comment on
attachment 219543
[details]
Proposed patch r=me.
WebKit Commit Bot
Comment 3
2013-12-18 10:29:41 PST
Comment on
attachment 219543
[details]
Proposed patch Clearing flags on attachment: 219543 Committed
r160777
: <
http://trac.webkit.org/changeset/160777
>
WebKit Commit Bot
Comment 4
2013-12-18 10:29:43 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug