Bug 125903 - CStack Branch: Fix varargs calls to work on C stack
Summary: CStack Branch: Fix varargs calls to work on C stack
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-17 18:33 PST by Michael Saboff
Modified: 2013-12-17 19:42 PST (History)
0 users

See Also:


Attachments
Patch (8.77 KB, patch)
2013-12-17 18:36 PST, Michael Saboff
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2013-12-17 18:33:04 PST
Calls to vararg functions need to set the stack pointer after the calleeFrame if calculated and before the call to loadVarargs().  Also, the computing of vararg callee frames need to be stack aligned.
Comment 1 Michael Saboff 2013-12-17 18:36:18 PST
Created attachment 219486 [details]
Patch
Comment 2 Michael Saboff 2013-12-17 19:42:47 PST
Committed r160746: <http://trac.webkit.org/changeset/160746>