Bug 125901 - Web Inspector: Some basic DebuggerAgent cleanup
Summary: Web Inspector: Some basic DebuggerAgent cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-17 18:28 PST by Joseph Pecoraro
Modified: 2013-12-18 11:22 PST (History)
6 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (3.73 KB, patch)
2013-12-17 18:30 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-12-17 18:28:08 PST
Some cleanup of DebuggerAgent.

• Inline a function only called in one place.
• Remove unnecessary virtual.
• Remove private enabled() function and just use member variable.
Comment 1 Joseph Pecoraro 2013-12-17 18:30:34 PST
Created attachment 219484 [details]
[PATCH] Proposed Fix
Comment 2 EFL EWS Bot 2013-12-17 19:15:56 PST
Comment on attachment 219484 [details]
[PATCH] Proposed Fix

Attachment 219484 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/47478062
Comment 3 Joseph Pecoraro 2013-12-18 10:54:08 PST
Comment on attachment 219484 [details]
[PATCH] Proposed Fix

efl-wk2 bot looks like it was cancelled. I'm going to cq+.
Comment 4 WebKit Commit Bot 2013-12-18 11:22:57 PST
Comment on attachment 219484 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 219484

Committed r160780: <http://trac.webkit.org/changeset/160780>
Comment 5 WebKit Commit Bot 2013-12-18 11:22:59 PST
All reviewed patches have been landed.  Closing bug.