Bug 125899 - [MSE] Add per-track signalling between SourceBuffer and SourceBufferPrivate.
Summary: [MSE] Add per-track signalling between SourceBuffer and SourceBufferPrivate.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks: 125905
  Show dependency tree / graph
 
Reported: 2013-12-17 18:22 PST by Jer Noble
Modified: 2013-12-17 22:46 PST (History)
3 users (show)

See Also:

Attachments
Patch (12.62 KB, patch)
2013-12-17 18:31 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2013-12-17 18:22:23 PST 
[MSE] Add per-track signalling between SourceBuffer and SourceBufferPrivate.
Comment 1 Jer Noble 2013-12-17 18:31:04 PST 
Created attachment 219485 [details]
Patch
Comment 2 Eric Carlson 2013-12-17 18:56:01 PST 
Comment on attachment 219485 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219485&action=review

> Source/WebCore/Modules/mediasource/SourceBuffer.h:143
> +    struct TrackBuffer;

Don't we usually forward declare structs and classes above the class?
Comment 3 Jer Noble 2013-12-17 22:01:38 PST 
(In reply to comment #2)
> (From update of attachment 219485 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219485&action=review
> 
> > Source/WebCore/Modules/mediasource/SourceBuffer.h:143
> > +    struct TrackBuffer;
> 
> Don't we usually forward declare structs and classes above the class?

Usually, yes, but this is a nested struct. It has to be declared within the declaration of SourceBuffer.
Comment 4 WebKit Commit Bot 2013-12-17 22:46:34 PST 
Comment on attachment 219485 [details]
Patch

Clearing flags on attachment: 219485

Committed r160754: <http://trac.webkit.org/changeset/160754>
Comment 5 WebKit Commit Bot 2013-12-17 22:46:36 PST 
All reviewed patches have been landed.  Closing bug.