Bug 125893 - REGRESSION(r157354-r157355): 2.6% regression on Dromaeo/cssquery-jquery
Summary: REGRESSION(r157354-r157355): 2.6% regression on Dromaeo/cssquery-jquery
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-17 17:24 PST by Ryosuke Niwa
Modified: 2013-12-18 15:05 PST (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Darin Adler 2013-12-18 09:30:38 PST
r157355 was supposed to just be a refactoring and should not have had any performance impact.
Comment 2 Darin Adler 2013-12-18 09:31:25 PST
I re-read http://trac.webkit.org/changeset/157355 and I can’t spot any change that should have had performance impact.
Comment 3 Andreas Kling 2013-12-18 10:10:45 PST
I think <http://trac.webkit.org/changeset/157354> is the likely culprit here.
Comment 4 Darin Adler 2013-12-18 10:18:47 PST
I guess I misunderstood the title of the bug. I assumed it meant that r157354 was known to fast and r157355 was known to be slow.
Comment 5 Darin Adler 2013-12-18 10:20:54 PST
r157354 was supposed to just be a refactoring and should not have had any performance impact.

I re-read http://trac.webkit.org/changeset/157354 and I can’t spot any change that should have had performance impact.
Comment 6 Ryosuke Niwa 2013-12-18 13:48:54 PST
This regression is hardly noticeable on my local machine so it could be something to do with memory alignment and the order file.
Comment 7 Ryosuke Niwa 2013-12-18 15:05:35 PST
CSS Query 

r157352: http://dromaeo.com/?id=212262

8429.08runs/s (Total)
DOM Query (Dojo): 7327.92runs/s
DOM Query (ExtJS): 5174.90runs/s
DOM Query (Mootools): 11909.97runs/s
DOM Query (Prototype): 9965.06runs/s
DOM Query (Yahoo UI): 5969.95runs/s
DOM Query (jQuery): 13193.79runs/s

r157355: http://dromaeo.com/?id=212266

8484.89runs/s (Total)
DOM Query (Dojo): 7488.50runs/s
DOM Query (ExtJS): 5400.73runs/s
DOM Query (Mootools): 11823.50runs/s
DOM Query (Prototype): 9950.53runs/s
DOM Query (Yahoo UI): 5940.33runs/s
DOM Query (jQuery): 13064.93runs/s

I guess the change is with in the margin of errors here :(