Bug 125872 - DatabaseProcess: Pipe through object store IDs and transaction mode for "openTransaction"
Summary: DatabaseProcess: Pipe through object store IDs and transaction mode for "open...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 124521
  Show dependency tree / graph
 
Reported: 2013-12-17 14:05 PST by Brady Eidson
Modified: 2013-12-17 16:09 PST (History)
3 users (show)

See Also:

Attachments
Patch v1 (26.14 KB, patch)
2013-12-17 14:10 PST, Brady Eidson 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2013-12-17 14:05:24 PST 
DatabaseProcess: Pipe through object store IDs and transaction mode for "openTransaction"
Comment 1 Brady Eidson 2013-12-17 14:10:27 PST 
Created attachment 219452 [details]
Patch v1
Comment 2 Alexey Proskuryakov 2013-12-17 15:00:38 PST 
Comment on attachment 219452 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=219452&action=review

> Source/WebCore/Modules/indexeddb/IndexedDB.h:41
>  enum TransactionMode {
> +    TransactionModeMinimum = 0,
>      TransactionReadOnly = 0,
>      TransactionReadWrite = 1,
> -    TransactionVersionChange = 2
> +    TransactionVersionChange = 2,
> +    TransactionModeMaximum = 2,
>  };

I'd use an enum class now:

enum class TransactionMode {
    ReadOnly = 0,
    ReadWrite = 1
    VersionChange = 2,
};
const unsigned maximumTransactionMode = 2;

(not sure why the minimum can't just be assumed 0).
Comment 3 Brady Eidson 2013-12-17 16:09:50 PST 
http://trac.webkit.org/changeset/160732