Bug 125872 – DatabaseProcess: Pipe through object store IDs and transaction mode for "openTransaction"

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

DatabaseProcess: Pipe through object store IDs and transaction mode for "openTransaction"

[Brady Eidson]

Created attachment 219452 [details]
Patch v1

[Alexey Proskuryakov]

Comment on attachment 219452 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=219452&action=review

> Source/WebCore/Modules/indexeddb/IndexedDB.h:41
>  enum TransactionMode {
> +    TransactionModeMinimum = 0,
>      TransactionReadOnly = 0,
>      TransactionReadWrite = 1,
> -    TransactionVersionChange = 2
> +    TransactionVersionChange = 2,
> +    TransactionModeMaximum = 2,
>  };

I'd use an enum class now:

enum class TransactionMode {
    ReadOnly = 0,
    ReadWrite = 1
    VersionChange = 2,
};
const unsigned maximumTransactionMode = 2;

(not sure why the minimum can't just be assumed 0).

[Brady Eidson]

http://trac.webkit.org/changeset/160732