Bug 125866 - Revise filter-build-webkit to deal with Windows logs
Summary: Revise filter-build-webkit to deal with Windows logs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Unspecified
: P2 Enhancement
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-17 12:22 PST by Brent Fulgham
Modified: 2013-12-17 13:17 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.76 KB, patch)
2013-12-17 12:25 PST, Brent Fulgham 		ddkilzer: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2013-12-17 12:22:43 PST 
Revise the "filter-build-webkit" script to do a better job of stripping uninteresting cruft from our build logs.
Comment 1 Brent Fulgham 2013-12-17 12:25:22 PST 
Created attachment 219440 [details]
Patch
Comment 2 Lucas Forschler 2013-12-17 12:29:59 PST 
In addition to this patch, I believe we will need to update the buildbot master config to pass in the platform parameter for windows.
Comment 3 David Kilzer (:ddkilzer) 2013-12-17 12:59:40 PST 
Comment on attachment 219440 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219440&action=review

r=me

> Tools/Scripts/filter-build-webkit:92
> +..-p|--platform Logfile type (default: mac)

What are the periods for?

Would be nice if you used $platform here in case the default ever changes.  :)

  -p|--platform Logfile type (default: $platform)
Comment 4 Brent Fulgham 2013-12-17 13:16:09 PST 
Comment on attachment 219440 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219440&action=review

>> Tools/Scripts/filter-build-webkit:92
>> +..-p|--platform Logfile type (default: mac)
> 
> What are the periods for?
> 
> Would be nice if you used $platform here in case the default ever changes.  :)
> 
>   -p|--platform Logfile type (default: $platform)

Periods should NOT be there. I'll fix.

I'll also change to $platform - great idea!
Comment 5 Brent Fulgham 2013-12-17 13:17:30 PST 
Committed r160726: <http://trac.webkit.org/changeset/160726>