RESOLVED FIXED125866
Revise filter-build-webkit to deal with Windows logs 
https://bugs.webkit.org/show_bug.cgi?id=125866
Summary Revise filter-build-webkit to deal with Windows logs
Brent Fulgham
Reported 2013-12-17 12:22:43 PST
Revise the "filter-build-webkit" script to do a better job of stripping uninteresting cruft from our build logs.
Attachments
Patch (5.76 KB, patch)
2013-12-17 12:25 PST, Brent Fulgham 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2013-12-17 12:25:22 PST
Created attachment 219440 [details] Patch
Lucas Forschler
Comment 2 2013-12-17 12:29:59 PST
In addition to this patch, I believe we will need to update the buildbot master config to pass in the platform parameter for windows.
David Kilzer (:ddkilzer)
Comment 3 2013-12-17 12:59:40 PST
Comment on attachment 219440 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219440&action=review r=me > Tools/Scripts/filter-build-webkit:92 > +..-p|--platform Logfile type (default: mac) What are the periods for? Would be nice if you used $platform here in case the default ever changes. :) -p|--platform Logfile type (default: $platform)
Brent Fulgham
Comment 4 2013-12-17 13:16:09 PST
Comment on attachment 219440 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219440&action=review >> Tools/Scripts/filter-build-webkit:92 >> +..-p|--platform Logfile type (default: mac) > > What are the periods for? > > Would be nice if you used $platform here in case the default ever changes. :) > > -p|--platform Logfile type (default: $platform) Periods should NOT be there. I'll fix. I'll also change to $platform - great idea!
Brent Fulgham
Comment 5 2013-12-17 13:17:30 PST
Committed r160726: <http://trac.webkit.org/changeset/160726>
Note You need to log in before you can comment on or make changes to this bug.