RESOLVED FIXED 125853
prepare-ChangeLog doesn't handle templates properly 
https://bugs.webkit.org/show_bug.cgi?id=125853
Summary prepare-ChangeLog doesn't handle templates properly
Csaba Osztrogonác
Reported 2013-12-17 04:58:16 PST
A simple diff: --------------- diff --git a/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp b/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp index bbcddd2..d3863d6 100644 --- a/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp +++ b/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp @@ -41,6 +41,7 @@ namespace CoreIPC { void ArgumentCoder<ResourceRequest>::encodePlatformData(ArgumentEncoder& encoder, const ResourceRequest& resourceRequest) { + // foo encoder << static_cast<uint32_t>(resourceRequest.soupMessageFlags()); } The generated ChangeLog entry: ------------------------------- * Shared/soup/WebCoreArgumentCodersSoup.cpp: (CoreIPC::::encodePlatformData):
Attachments
Proposed patch (1.26 KB, patch)
2013-12-18 01:55 PST, Dániel Bátyai 		no flags
DetailsFormatted DiffDiff
Proposed patch (1.24 KB, patch)
2013-12-18 02:06 PST, Dániel Bátyai 		no flags
DetailsFormatted DiffDiff
Proposed patch (1.25 KB, patch)
2013-12-18 06:15 PST, Dániel Bátyai 		ossy: review-
ossy: commit-queue-
DetailsFormatted DiffDiff
Proposed patch (2.49 KB, patch)
2013-12-18 08:27 PST, Dániel Bátyai 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dániel Bátyai
Comment 1 2013-12-18 01:55:31 PST
Created attachment 219512 [details] Proposed patch
Dániel Bátyai
Comment 2 2013-12-18 02:06:00 PST
Created attachment 219513 [details] Proposed patch
Peter Gal
Comment 3 2013-12-18 05:16:00 PST
Comment on attachment 219513 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=219513&action=review > Tools/ChangeLog:3 > + Fixed template handling in prepare-ChangeLog This line does not match the bug entry's title.
Dániel Bátyai
Comment 4 2013-12-18 06:15:55 PST
Created attachment 219530 [details] Proposed patch
Csaba Osztrogonác
Comment 5 2013-12-18 07:53:07 PST
Comment on attachment 219530 [details] Proposed patch The fix looks good to me, but please add a unittest.
Dániel Bátyai
Comment 6 2013-12-18 08:27:06 PST
Created attachment 219537 [details] Proposed patch
WebKit Commit Bot
Comment 7 2013-12-18 09:23:05 PST
Comment on attachment 219537 [details] Proposed patch Clearing flags on attachment: 219537 Committed r160769: <http://trac.webkit.org/changeset/160769>
WebKit Commit Bot
Comment 8 2013-12-18 09:23:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.