Bug 125853 - prepare-ChangeLog doesn't handle templates properly
Summary: prepare-ChangeLog doesn't handle templates properly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-17 04:58 PST by Csaba Osztrogonác
Modified: 2013-12-18 09:23 PST (History)
6 users (show)

See Also:

Attachments
Proposed patch (1.26 KB, patch)
2013-12-18 01:55 PST, Dániel Bátyai 		no flags Details | Formatted Diff | Diff
Proposed patch (1.24 KB, patch)
2013-12-18 02:06 PST, Dániel Bátyai 		no flags Details | Formatted Diff | Diff
Proposed patch (1.25 KB, patch)
2013-12-18 06:15 PST, Dániel Bátyai 		ossy: review-
ossy: commit-queue-
Details | Formatted Diff | Diff
Proposed patch (2.49 KB, patch)
2013-12-18 08:27 PST, Dániel Bátyai 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2013-12-17 04:58:16 PST 
A simple diff:
---------------
diff --git a/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp b/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp
index bbcddd2..d3863d6 100644
--- a/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp
+++ b/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp
@@ -41,6 +41,7 @@ namespace CoreIPC {

 void ArgumentCoder<ResourceRequest>::encodePlatformData(ArgumentEncoder& encoder, const ResourceRequest& resourceRequest)
 {
+    // foo
     encoder << static_cast<uint32_t>(resourceRequest.soupMessageFlags());
 }

The generated ChangeLog entry:
-------------------------------
        * Shared/soup/WebCoreArgumentCodersSoup.cpp:
        (CoreIPC::::encodePlatformData):
Comment 1 Dániel Bátyai 2013-12-18 01:55:31 PST 
Created attachment 219512 [details]
Proposed patch
Comment 2 Dániel Bátyai 2013-12-18 02:06:00 PST 
Created attachment 219513 [details]
Proposed patch
Comment 3 Peter Gal 2013-12-18 05:16:00 PST 
Comment on attachment 219513 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219513&action=review

> Tools/ChangeLog:3
> +        Fixed template handling in prepare-ChangeLog

This line does not match the bug entry's title.
Comment 4 Dániel Bátyai 2013-12-18 06:15:55 PST 
Created attachment 219530 [details]
Proposed patch
Comment 5 Csaba Osztrogonác 2013-12-18 07:53:07 PST 
Comment on attachment 219530 [details]
Proposed patch

The fix looks good to me, but please add a unittest.
Comment 6 Dániel Bátyai 2013-12-18 08:27:06 PST 
Created attachment 219537 [details]
Proposed patch
Comment 7 WebKit Commit Bot 2013-12-18 09:23:05 PST 
Comment on attachment 219537 [details]
Proposed patch

Clearing flags on attachment: 219537

Committed r160769: <http://trac.webkit.org/changeset/160769>
Comment 8 WebKit Commit Bot 2013-12-18 09:23:07 PST 
All reviewed patches have been landed.  Closing bug.