Bug 125852 - [GStreamer] video/audio seeking is not unified.
Summary: [GStreamer] video/audio seeking is not unified.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-17 04:42 PST by Piotr Grad
Modified: 2013-12-23 05:11 PST (History)
9 users (show)

See Also:

Attachments
Patch (6.14 KB, patch)
2013-12-17 05:22 PST, Piotr Grad 		no flags Details | Formatted Diff | Diff
patch (6.09 KB, patch)
2013-12-23 03:39 PST, Piotr Grad 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Grad 2013-12-17 04:42:04 PST 
Seeking should be unified in that way we are always sure negative playback rate is always taken into account.
Comment 1 Piotr Grad 2013-12-17 04:42:29 PST 
Already working on solution.
Comment 2 Piotr Grad 2013-12-17 05:22:07 PST 
Created attachment 219411 [details]
Patch
Comment 3 Philippe Normand 2013-12-17 05:50:24 PST 
Comment on attachment 219411 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219411&action=review

> Source/WebCore/ChangeLog:11
> +        Test: media/video-seek-with-negative-playback.html

This is skipped in EFL but not in GTK, it seems. I guess it can now be unskipped?

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:614
> +bool MediaPlayerPrivateGStreamer::seekIncludingRate(gint64 position, float rate, GstSeekFlags seekType)

Hum what about doSeek() ? Having only the rate mentioned in the name is a bit odd.
Comment 4 Piotr Grad 2013-12-23 03:39:46 PST 
Created attachment 219904 [details]
patch
Comment 5 Piotr Grad 2013-12-23 03:55:01 PST 
(In reply to comment #3)
> (From update of attachment 219411 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219411&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        Test: media/video-seek-with-negative-playback.html
> 
> This is skipped in EFL but not in GTK, it seems. I guess it can now be unskipped?
> 
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:614
> > +bool MediaPlayerPrivateGStreamer::seekIncludingRate(gint64 position, float rate, GstSeekFlags seekType)
> 
> Hum what about doSeek() ? Having only the rate mentioned in the name is a bit odd.

Unfortunatelly this test is still flaky for EFL becouse of some race condition.
Comment 6 WebKit Commit Bot 2013-12-23 05:11:42 PST 
Comment on attachment 219904 [details]
patch

Clearing flags on attachment: 219904

Committed r160992: <http://trac.webkit.org/changeset/160992>
Comment 7 WebKit Commit Bot 2013-12-23 05:11:45 PST 
All reviewed patches have been landed.  Closing bug.