Bug 125838 - Remove dead code for reflected attributes from audio, video, and track elements
Summary: Remove dead code for reflected attributes from audio, video, and track elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 125822
Blocks:
  Show dependency tree / graph
 
Reported: 2013-12-16 22:59 PST by Ryosuke Niwa
Modified: 2013-12-17 20:14 PST (History)
14 users (show)

See Also:

Attachments
Removes the dead code (4.62 KB, patch)
2013-12-16 23:00 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Reuploaded for EWS (4.56 KB, patch)
2013-12-17 16:06 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Reuploaded again for EWS (4.61 KB, patch)
2013-12-17 16:31 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-12-16 22:59:09 PST 
Merge https://chromium.googlesource.com/chromium/blink/+/310514e2f0fd934975b841d463bad0cd62e6fd64

Where [Reflect] is used in the IDL, the getters and setters in C++ are
only for internal convenience, and these were unused.
Comment 1 Ryosuke Niwa 2013-12-16 23:00:03 PST 
Created attachment 219399 [details]
Removes the dead code
Comment 2 EFL EWS Bot 2013-12-17 10:15:54 PST 
Comment on attachment 219399 [details]
Removes the dead code

Attachment 219399 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/50088293
Comment 3 EFL EWS Bot 2013-12-17 10:24:39 PST 
Comment on attachment 219399 [details]
Removes the dead code

Attachment 219399 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/49938294
Comment 4 Build Bot 2013-12-17 10:43:58 PST 
Comment on attachment 219399 [details]
Removes the dead code

Attachment 219399 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/46338360
Comment 5 kov's GTK+ EWS bot 2013-12-17 10:59:08 PST 
Comment on attachment 219399 [details]
Removes the dead code

Attachment 219399 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/48178292
Comment 6 Build Bot 2013-12-17 11:05:27 PST 
Comment on attachment 219399 [details]
Removes the dead code

Attachment 219399 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/48178291
Comment 7 Ryosuke Niwa 2013-12-17 16:06:11 PST 
Created attachment 219462 [details]
Reuploaded for EWS
Comment 8 Build Bot 2013-12-17 16:28:03 PST 
Comment on attachment 219462 [details]
Reuploaded for EWS

Attachment 219462 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/47628269
Comment 9 Ryosuke Niwa 2013-12-17 16:31:41 PST 
Created attachment 219467 [details]
Reuploaded again for EWS
Comment 10 WebKit Commit Bot 2013-12-17 20:14:47 PST 
Comment on attachment 219467 [details]
Reuploaded again for EWS

Clearing flags on attachment: 219467

Committed r160747: <http://trac.webkit.org/changeset/160747>
Comment 11 WebKit Commit Bot 2013-12-17 20:14:50 PST 
All reviewed patches have been landed.  Closing bug.