Bug 125821 - Avoid indirect function calls for custom getters
Summary: Avoid indirect function calls for custom getters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-16 18:30 PST by Oliver Hunt
Modified: 2013-12-20 13:04 PST (History)
1 user (show)

See Also:


Attachments
Patch (4.44 KB, patch)
2013-12-16 18:32 PST, Oliver Hunt
mhahnenberg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2013-12-16 18:30:00 PST
Avoid indirect function calls for custom getters
Comment 1 Oliver Hunt 2013-12-16 18:32:45 PST
Created attachment 219379 [details]
Patch
Comment 2 Mark Hahnenberg 2013-12-16 18:37:47 PST
Comment on attachment 219379 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219379&action=review

r=me

> Source/JavaScriptCore/ChangeLog:13
> +        Unfortunately this only works in JSVALUE64 at the moment as there
> +        is not an obvious way to pass two EncodedJSValues uniformly over
> +        the various effected JITs.

Maybe file a followup bug for 32-bit?
Comment 3 Oliver Hunt 2013-12-16 18:40:18 PST
Committed r160688: <http://trac.webkit.org/changeset/160688>
Comment 4 Ryosuke Niwa 2013-12-20 13:04:36 PST
This patch appears to have improved Dromaeo/dim-traverse by 15%:

https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mountainlion%22%2C%22Dromaeo%2Fdom-traverse%3ARuns%22%5D%5D