Bug 125818 - Web Inspector: Use JSC::SourceID and JSC::BreakpointID instead of WebCore dups
Summary: Web Inspector: Use JSC::SourceID and JSC::BreakpointID instead of WebCore dups
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-16 17:05 PST by Joseph Pecoraro
Modified: 2013-12-16 17:33 PST (History)
6 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (30.02 KB, patch)
2013-12-16 17:06 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-12-16 17:05:00 PST
Since WebKit no longer needs to support multiple JavaScript engines, we should just start using JSC types throughout Inspector source. SourceID and BreakpointID are good examples, they are just typedefs of the JSC types.
Comment 1 Joseph Pecoraro 2013-12-16 17:06:46 PST
Created attachment 219373 [details]
[PATCH] Proposed Fix
Comment 2 Mark Lam 2013-12-16 17:13:11 PST
r=me
Comment 3 WebKit Commit Bot 2013-12-16 17:33:37 PST
Comment on attachment 219373 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 219373

Committed r160682: <http://trac.webkit.org/changeset/160682>
Comment 4 WebKit Commit Bot 2013-12-16 17:33:39 PST
All reviewed patches have been landed.  Closing bug.