Bug 125816 - DatabaseProcess: Plumb through messaging for the 4 basic transaction operations
Summary: DatabaseProcess: Plumb through messaging for the 4 basic transaction operations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 124521
  Show dependency tree / graph
 
Reported: 2013-12-16 16:41 PST by Brady Eidson
Modified: 2013-12-16 17:09 PST (History)
0 users

See Also:

Attachments
Patch v1 (28.18 KB, patch)
2013-12-16 16:46 PST, Brady Eidson 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2013-12-16 16:41:06 PST 
DatabaseProcess: Plumb through messaging for the 4 basic transaction operations
Comment 1 Brady Eidson 2013-12-16 16:46:53 PST 
Created attachment 219370 [details]
Patch v1
Comment 2 Alexey Proskuryakov 2013-12-16 17:01:42 PST 
Comment on attachment 219370 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=219370&action=review

r=me

> Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:234
> +        LOG_ERROR("Attempting to queue transaction operation when an operation is already pending");

An operation or the operation? Should it be an assertion?

I guess I'm not sure what this error means, besides "ping Brady on IRC" :)

> Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:255
> +

Looks like too much whitespace.
Comment 3 Brady Eidson 2013-12-16 17:06:15 PST 
(In reply to comment #2)
> (From update of attachment 219370 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219370&action=review
> 
> r=me
> 
> > Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:234
> > +        LOG_ERROR("Attempting to queue transaction operation when an operation is already pending");
> 
> An operation or the operation? Should it be an assertion?

"an" operation.

The reason this is not an ASSERT is because it directly relies on an ID that was sent over the wire from another process, so it can't be trusted as an invariant.

Will try to clarify the error message.

> > Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:255
> > +

Yup!  Thanks!
Comment 4 Brady Eidson 2013-12-16 17:09:21 PST 
http://trac.webkit.org/changeset/160678