Bug 125809 – Add some missing functions to MacroAssembler

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Hahnenberg]

There's a few missing functions that are needed for GenGC in MacroAssembler for a couple platforms.

[Mark Hahnenberg]

Created attachment 219360 [details]
patch

[EFL EWS Bot]

Comment on attachment 219360 [details]
patch

Attachment 219360 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/47078105

[Mark Hahnenberg]

Created attachment 219361 [details]
patch

[WebKit Commit Bot]

Attachment 219361 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/assembler/AbstractMacroAssembler.h', u'Source/JavaScriptCore/assembler/AssemblerBuffer.h', u'Source/JavaScriptCore/assembler/LinkBuffer.cpp', u'Source/JavaScriptCore/assembler/MacroAssembler.h', u'Source/JavaScriptCore/assembler/MacroAssemblerARM64.h', u'Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h', '--commit-queue']" exit_code: 1
ERROR: Source/JavaScriptCore/assembler/MacroAssembler.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Hahnenberg]

Created attachment 219362 [details]
patch

[EFL EWS Bot]

Comment on attachment 219362 [details]
patch

Attachment 219362 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/46658256

[Mark Hahnenberg]

Created attachment 219364 [details]
patch

[WebKit Commit Bot]

Comment on attachment 219364 [details]
patch

Rejecting attachment 219364 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 219364, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
    -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 160676 = aa1e414b99564f9ee77ac2384796a17b39d2a576
r160677 = 6ad9a33a184ad1d60c3a0d6ac90aea7d7a9ea40e
r160678 = e9712876447b8eb2e1f26206ac99197ca00ec25e
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.appspot.com/results/50018100

[Mark Hahnenberg]

(In reply to comment #8)
> (From update of attachment 219364 [details])
> Rejecting attachment 219364 [details] from commit-queue.
> 
> Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 219364, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit
> 
> Last 500 characters of output:
>     -> origin/master
> Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
> Currently at 160676 = aa1e414b99564f9ee77ac2384796a17b39d2a576
> r160677 = 6ad9a33a184ad1d60c3a0d6ac90aea7d7a9ea40e
> r160678 = e9712876447b8eb2e1f26206ac99197ca00ec25e
> Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
> First, rewinding head to replay your work on top of it...
> Fast-forwarded master to refs/remotes/origin/master.
> 
> Full output: http://webkit-queues.appspot.com/results/50018100

Would help if I had a ChangeLog :-/

[Mark Hahnenberg]

Committed r160680: <http://trac.webkit.org/changeset/160680>