RESOLVED FIXED 125807
Apply overhang shadow and linen to UI-side layers 
https://bugs.webkit.org/show_bug.cgi?id=125807
Summary Apply overhang shadow and linen to UI-side layers
Simon Fraser (smfr)
Reported 2013-12-16 15:12:56 PST
Apply overhand shadow and linen to UI-side layers
Attachments
Patch (32.41 KB, patch)
2013-12-16 15:19 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (32.78 KB, patch)
2013-12-16 15:21 PST, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2013-12-16 15:19:57 PST
Created attachment 219358 [details] Patch
Simon Fraser (smfr)
Comment 2 2013-12-16 15:21:07 PST
Created attachment 219359 [details] Patch
Tim Horton
Comment 3 2013-12-16 15:28:14 PST
Comment on attachment 219359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219359&action=review > Source/WebCore/platform/mac/ScrollbarThemeMac.mm:560 > + RetainPtr<CGPathRef> shadowPath = adoptCF(CGPathCreateWithRect(layer.bounds, NULL)); > + layer.shadowPath = shadowPath.get(); not sure this temporary is useful > Source/WebCore/platform/mac/ScrollbarThemeMac.mm:565 > + layer.shadowPath = nil; I think you should drop shadow opacity too, otherwise CA will try to figure out the opaque region of the layer because it doesn't have a shadowPath. > Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:652 > + if (layerProperties.changedProperties & RemoteLayerTreeTransaction::CustomAppearanceChanged) > + dumpProperty<GraphicsLayer::CustomAppearance>(ts, "customAppearance", layerProperties.customAppearance); > + Ideally this would print something useful but not necessary right now. > Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:529 > +void PlatformCALayerRemote::updateCustomAppearance(WebCore::GraphicsLayer::CustomAppearance customAppearance) No WebCore:: here
Simon Fraser (smfr)
Comment 4 2013-12-16 15:47:10 PST
<rdar://problem/15662167>
Simon Fraser (smfr)
Comment 5 2013-12-16 16:10:48 PST
https://trac.webkit.org/r160672
Tim Horton
Comment 6 2013-12-17 00:13:44 PST
This seems to have disappeared the shadow in traditional compositing. Not sure why, yet.
Note You need to log in before you can comment on or make changes to this bug.