Bug 125795 – [Win] Remove dead code after conversion to VS2013

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Brent Fulgham]

Remove dead code left after migrating to require VS2013 to build.

[Brent Fulgham]

Created attachment 219346 [details]
Patch

[EFL EWS Bot]

Comment on attachment 219346 [details]
Patch

Attachment 219346 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/50088031

[Anders Carlsson]

Comment on attachment 219346 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219346&action=review

> Source/WTF/wtf/Compiler.h:-73
> -#if _MSC_VER < 1600
> -#define WTF_COMPILER_MSVC9_OR_LOWER 1
> -#endif

I think you should add an #error if someone tries to use an old version of VS2013.

> Source/WTF/wtf/StdLibExtras.h:-321
> -#if (defined(_MSC_VER) && _MSC_VER < 1700) || (COMPILER(GCC) && !COMPILER(CLANG) && !GCC_VERSION_AT_LEAST(4, 8, 1))
> -
> -// Work-around for Pre-C++11 syntax in MSVC 2010, and prior as well as GCC < 4.8.1.
> -namespace std {
> -    template<class T> struct is_trivially_destructible {
> -        static const bool value = std::has_trivial_destructor<T>::value;
> -    };
> -}
> -#endif

This workaround needs to be left in for older GCCs.

> Source/WTF/wtf/StdLibExtras.h:-354
> -// MSVC 2013 supports std::make_unique already.
> -#if !defined(_MSC_VER) || _MSC_VER < 1800
> -    template<class T> struct _Unique_if {
> -        typedef unique_ptr<T> _Single_object;
> -    };
> -
> -    template<class T> struct _Unique_if<T[]> {
> -        typedef unique_ptr<T[]> _Unknown_bound;
> -    };
> -
> -    template<class T, size_t N> struct _Unique_if<T[N]> {
> -        typedef void _Known_bound;
> -    };
> -
> -    template<class T, class... Args> inline typename _Unique_if<T>::_Single_object
> -    make_unique(Args&&... args)
> -    {
> -        return unique_ptr<T>(new T(std::forward<Args>(args)...));
> -    }
> -
> -    template<class T> inline typename _Unique_if<T>::_Unknown_bound
> -    make_unique(size_t n)
> -    {
> -        typedef typename remove_extent<T>::type U;
> -        return unique_ptr<T>(new U[n]());
> -    }
> -    
> -    template<class T, class... Args> typename _Unique_if<T>::_Known_bound
> -    make_unique(Args&&...) = delete;
> -#endif

This workaround is used by everyone except VS2013!

[kov's GTK+ EWS bot]

Comment on attachment 219346 [details]
Patch

Attachment 219346 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/50108001

[Brent Fulgham]

(In reply to comment #3)
> (From update of attachment 219346 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219346&action=review
> 
> > Source/WTF/wtf/Compiler.h:-73
> > -#if _MSC_VER < 1600
> > -#define WTF_COMPILER_MSVC9_OR_LOWER 1
> > -#endif
> 
> I think you should add an #error if someone tries to use an old version of VS2013.

ok!

> > Source/WTF/wtf/StdLibExtras.h:-321
> > -#if (defined(_MSC_VER) && _MSC_VER < 1700) || (COMPILER(GCC) && !COMPILER(CLANG) && !GCC_VERSION_AT_LEAST(4, 8, 1))
> > -
> > -// Work-around for Pre-C++11 syntax in MSVC 2010, and prior as well as GCC < 4.8.1.
> > -namespace std {
> > -    template<class T> struct is_trivially_destructible {
> > -        static const bool value = std::has_trivial_destructor<T>::value;
> > -    };
> > -}
> > -#endif
> 
> This workaround needs to be left in for older GCCs.

ok!

> > Source/WTF/wtf/StdLibExtras.h:-354
> > -// MSVC 2013 supports std::make_unique already.
> > -#if !defined(_MSC_VER) || _MSC_VER < 1800
> > -    template<class T> struct _Unique_if {
> > -        typedef unique_ptr<T> _Single_object;
> 
> This workaround is used by everyone except VS2013!

Whoops!

[Build Bot]

Comment on attachment 219346 [details]
Patch

Attachment 219346 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/44318102

[Brent Fulgham]

Created attachment 219349 [details]
Patch

[Brent Fulgham]

Committed r160671: <http://trac.webkit.org/changeset/160671>