Bug 125785 - Additional refinement in MathMLSelectElement toggle implementation
Summary: Additional refinement in MathMLSelectElement toggle implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on: 120059
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-16 10:17 PST by Darin Adler
Modified: 2013-12-18 09:58 PST (History)
4 users (show)

See Also:


Attachments
Patch (5.05 KB, patch)
2013-12-16 10:19 PST, Darin Adler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2013-12-16 10:17:18 PST
Additional refinement in MathMLSelectElement toggle implementation
Comment 1 Darin Adler 2013-12-16 10:19:26 PST
Created attachment 219326 [details]
Patch
Comment 2 Darin Adler 2013-12-16 10:21:55 PST
Comment on attachment 219326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219326&action=review

> Source/WebCore/mathml/MathMLSelectElement.cpp:161
>      // We update the attribute value of the selection attribute.
>      // This will also call MathMLSelectElement::attributeChanged to update the selected child.

I should probably cut down this comment, too. It spends too many words restating exactly what the code below says, and should limit itself to the non-obvious part.
Comment 3 Andreas Kling 2013-12-18 02:18:12 PST
Comment on attachment 219326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219326&action=review

r=me

>> Source/WebCore/mathml/MathMLSelectElement.cpp:161
>>      // This will also call MathMLSelectElement::attributeChanged to update the selected child.
> 
> I should probably cut down this comment, too. It spends too many words restating exactly what the code below says, and should limit itself to the non-obvious part.

Your choice. Leaving cq? set.
Comment 4 Darin Adler 2013-12-18 09:32:08 PST
Comment on attachment 219326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219326&action=review

>>> Source/WebCore/mathml/MathMLSelectElement.cpp:161
>>>      // This will also call MathMLSelectElement::attributeChanged to update the selected child.
>> 
>> I should probably cut down this comment, too. It spends too many words restating exactly what the code below says, and should limit itself to the non-obvious part.
> 
> Your choice. Leaving cq? set.

I’ll come back and do that later.
Comment 5 WebKit Commit Bot 2013-12-18 09:58:56 PST
Comment on attachment 219326 [details]
Patch

Clearing flags on attachment: 219326

Committed r160771: <http://trac.webkit.org/changeset/160771>
Comment 6 WebKit Commit Bot 2013-12-18 09:58:58 PST
All reviewed patches have been landed.  Closing bug.