Bug 125784 – [iOS] Upstream WebCore/svg changes

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Daniel Bates]

Upstream the iOS related changes to WebCore/svg.

[Daniel Bates]

Created attachment 219323 [details]
Patch

[Darin Adler]

Comment on attachment 219323 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219323&action=review

> Source/WebCore/svg/SVGAElement.cpp:239
> +#if PLATFORM(IOS)
> +bool SVGAElement::willRespondToMouseClickEvents()

I see no reason for this to be iOS-specific. Seems like we want it on all platforms.

> Source/WebCore/svg/SVGAElement.cpp:241
> +    return !href().isEmpty() || SVGGraphicsElement::willRespondToMouseClickEvents(); 

Should check isLink() rather than !href().isEmpty().

> Source/WebCore/svg/SVGElement.cpp:494
> +#if ENABLE(TOUCH_EVENTS) && PLATFORM(IOS)

Not sure I understand why the PLATFORM(IOS) is here.

[Daniel Bates]

(In reply to comment #2)
> (From update of attachment 219323 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219323&action=review
> 
> > Source/WebCore/svg/SVGAElement.cpp:239
> > +#if PLATFORM(IOS)
> > +bool SVGAElement::willRespondToMouseClickEvents()
> 
> I see no reason for this to be iOS-specific. Seems like we want it on all platforms.

Will compile for all platforms.

> 
> > Source/WebCore/svg/SVGAElement.cpp:241
> > +    return !href().isEmpty() || SVGGraphicsElement::willRespondToMouseClickEvents(); 
> 
> Should check isLink() rather than !href().isEmpty().

Will substitute isLink() for !href().isEmpty().

> 
> > Source/WebCore/svg/SVGElement.cpp:494
> > +#if ENABLE(TOUCH_EVENTS) && PLATFORM(IOS)
> 
> Not sure I understand why the PLATFORM(IOS) is here.

Will remove conjunct PLATFORM(IOS).

[Daniel Bates]

Committed r160668: <http://trac.webkit.org/changeset/160668>