Bug 125784 - [iOS] Upstream WebCore/svg changes
Summary: [iOS] Upstream WebCore/svg changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-16 09:26 PST by Daniel Bates
Modified: 2013-12-16 15:24 PST (History)
10 users (show)

See Also:

Attachments
Patch (3.84 KB, patch)
2013-12-16 09:28 PST, Daniel Bates 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2013-12-16 09:26:21 PST 
Upstream the iOS related changes to WebCore/svg.
Comment 1 Daniel Bates 2013-12-16 09:28:53 PST 
Created attachment 219323 [details]
Patch
Comment 2 Darin Adler 2013-12-16 09:44:48 PST 
Comment on attachment 219323 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219323&action=review

> Source/WebCore/svg/SVGAElement.cpp:239
> +#if PLATFORM(IOS)
> +bool SVGAElement::willRespondToMouseClickEvents()

I see no reason for this to be iOS-specific. Seems like we want it on all platforms.

> Source/WebCore/svg/SVGAElement.cpp:241
> +    return !href().isEmpty() || SVGGraphicsElement::willRespondToMouseClickEvents(); 

Should check isLink() rather than !href().isEmpty().

> Source/WebCore/svg/SVGElement.cpp:494
> +#if ENABLE(TOUCH_EVENTS) && PLATFORM(IOS)

Not sure I understand why the PLATFORM(IOS) is here.
Comment 3 Daniel Bates 2013-12-16 15:21:32 PST 
(In reply to comment #2)
> (From update of attachment 219323 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219323&action=review
> 
> > Source/WebCore/svg/SVGAElement.cpp:239
> > +#if PLATFORM(IOS)
> > +bool SVGAElement::willRespondToMouseClickEvents()
> 
> I see no reason for this to be iOS-specific. Seems like we want it on all platforms.

Will compile for all platforms.

> 
> > Source/WebCore/svg/SVGAElement.cpp:241
> > +    return !href().isEmpty() || SVGGraphicsElement::willRespondToMouseClickEvents(); 
> 
> Should check isLink() rather than !href().isEmpty().

Will substitute isLink() for !href().isEmpty().

> 
> > Source/WebCore/svg/SVGElement.cpp:494
> > +#if ENABLE(TOUCH_EVENTS) && PLATFORM(IOS)
> 
> Not sure I understand why the PLATFORM(IOS) is here.

Will remove conjunct PLATFORM(IOS).
Comment 4 Daniel Bates 2013-12-16 15:24:33 PST 
Committed r160668: <http://trac.webkit.org/changeset/160668>