RESOLVED FIXED 125777
[EFL] Make FTL buildable 
https://bugs.webkit.org/show_bug.cgi?id=125777
Summary [EFL] Make FTL buildable
Dániel Bátyai
Reported 2013-12-16 06:26:42 PST
Add ability to build JavaScriptCore with FTL.
Attachments
Proposed patch (6.90 KB, patch)
2013-12-16 06:28 PST, Dániel Bátyai 		no flags
DetailsFormatted DiffDiff
Proposed patch (7.22 KB, patch)
2013-12-16 06:40 PST, Dániel Bátyai 		no flags
DetailsFormatted DiffDiff
Proposed patch (9.53 KB, patch)
2013-12-16 07:08 PST, Dániel Bátyai 		no flags
DetailsFormatted DiffDiff
Proposed patch (9.52 KB, patch)
2013-12-16 07:26 PST, Dániel Bátyai 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dániel Bátyai
Comment 1 2013-12-16 06:28:57 PST
Created attachment 219309 [details] Proposed patch
WebKit Commit Bot
Comment 2 2013-12-16 06:30:09 PST
Attachment 219309 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/ftl/FTLOSREntry.cpp', u'Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp', u'Source/JavaScriptCore/llvm/library/config_llvm.h', u'Source/cmake/OptionsEfl.cmake', u'Source/cmakeconfig.h.cmake', '--commit-queue']" exit_code: 1 ERROR: ChangeLog:8: Line contains tab character. [whitespace/tab] [5] ERROR: Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/JavaScriptCore/CMakeLists.txt:593: Alphabetical sorting problem. "ftl/FTLOSRExit.cpp" should be before "ftl/FTLOSRExitCompiler.cpp". [list/order] [5] ERROR: Source/JavaScriptCore/CMakeLists.txt:617: There should be exactly one empty line instead of 0 between "bytecode" and "collector/handles". [list/emptyline] [5] ERROR: Source/JavaScriptCore/CMakeLists.txt:618: Alphabetical sorting problem. "debugger" should be before "collector/handles". [list/order] [5] Total errors found: 6 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dániel Bátyai
Comment 3 2013-12-16 06:40:22 PST
Created attachment 219310 [details] Proposed patch
Dániel Bátyai
Comment 4 2013-12-16 07:08:09 PST
Created attachment 219315 [details] Proposed patch Some files were missing from the previous patch
WebKit Commit Bot
Comment 5 2013-12-16 07:09:25 PST
Attachment 219315 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/llvm/InitializeLLVMLinux.cpp', u'Source/JavaScriptCore/llvm/library/config_llvm.h', u'Source/cmake/FindLLVM.cmake', u'Source/cmake/OptionsEfl.cmake', u'Source/cmakeconfig.h.cmake', '--commit-queue']" exit_code: 1 ERROR: Source/cmake/FindLLVM.cmake:12: No space before ")" [whitespace/parentheses] [5] ERROR: Source/cmake/FindLLVM.cmake:13: No space before ")" [whitespace/parentheses] [5] ERROR: Source/cmake/FindLLVM.cmake:14: No space before ")" [whitespace/parentheses] [5] Total errors found: 3 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dániel Bátyai
Comment 6 2013-12-16 07:26:57 PST
Created attachment 219317 [details] Proposed patch
Csaba Osztrogonác
Comment 7 2014-01-08 06:48:31 PST
Comment on attachment 219317 [details] Proposed patch LGTM, r=me.
WebKit Commit Bot
Comment 8 2014-01-08 07:17:29 PST
Comment on attachment 219317 [details] Proposed patch Clearing flags on attachment: 219317 Committed r161498: <http://trac.webkit.org/changeset/161498>
WebKit Commit Bot
Comment 9 2014-01-08 07:17:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.