Bug 125762 - CTTE: Convert more of SVG to use references
Summary: CTTE: Convert more of SVG to use references
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-15 19:19 PST by Sam Weinig
Modified: 2013-12-16 11:20 PST (History)
10 users (show)

See Also:

Attachments
Patch (51.61 KB, patch)
2013-12-15 19:19 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (51.50 KB, patch)
2013-12-15 20:38 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-12-15 19:19:10 PST 
CTTE: Convert more of SVG to use references
Comment 1 Sam Weinig 2013-12-15 19:19:42 PST 
Created attachment 219289 [details]
Patch
Comment 2 Darin Adler 2013-12-15 20:28:42 PST 
Comment on attachment 219289 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219289&action=review

> Source/WebCore/rendering/svg/RenderSVGResource.cpp:179
> +        if (RenderElement* renderer = element->renderer())

Could use auto instead of specifying RenderElement. Other places in the patch, too.
Comment 3 Sam Weinig 2013-12-15 20:38:20 PST 
Created attachment 219292 [details]
Patch
Comment 4 Darin Adler 2013-12-16 09:37:41 PST 
Comment on attachment 219292 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219292&action=review

Looks great. I spotted 6 “other places” you didn’t change.

> Source/WebCore/svg/SVGAnimateMotionElement.cpp:292
> +    if (RenderElement* renderer = targetElement->renderer())

One of the “other places”.

> Source/WebCore/svg/SVGAnimateMotionElement.cpp:307
> +        if (RenderElement* renderer = shadowTreeElement->renderer()) {

Another of the “other places”.

> Source/WebCore/svg/SVGFEImageElement.cpp:202
> +    RenderElement* parentRenderer = parent->renderer();

Another of the “other places”.

> Source/WebCore/svg/SVGFELightElement.cpp:217
> +    RenderElement* renderer = parent->renderer();

Another of the “other places”.

> Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.cpp:168
> +    RenderElement* renderer = parent->renderer();

Another of the “other places”.

> Source/WebCore/svg/SVGSVGElement.cpp:726
> +                if (RenderElement* renderer = svg->renderer())

Another of the “other places”.
Comment 5 Sam Weinig 2013-12-16 10:53:08 PST 
(In reply to comment #4)
> (From update of attachment 219292 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219292&action=review
> 
> Looks great. I spotted 6 “other places” you didn’t change.
> 
> > Source/WebCore/svg/SVGAnimateMotionElement.cpp:292
> > +    if (RenderElement* renderer = targetElement->renderer())
> 
> One of the “other places”.
> 
> > Source/WebCore/svg/SVGAnimateMotionElement.cpp:307
> > +        if (RenderElement* renderer = shadowTreeElement->renderer()) {
> 
> Another of the “other places”.
> 
> > Source/WebCore/svg/SVGFEImageElement.cpp:202
> > +    RenderElement* parentRenderer = parent->renderer();
> 
> Another of the “other places”.
> 
> > Source/WebCore/svg/SVGFELightElement.cpp:217
> > +    RenderElement* renderer = parent->renderer();
> 
> Another of the “other places”.
> 
> > Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.cpp:168
> > +    RenderElement* renderer = parent->renderer();
> 
> Another of the “other places”.
> 
> > Source/WebCore/svg/SVGSVGElement.cpp:726
> > +                if (RenderElement* renderer = svg->renderer())
> 
> Another of the “other places”.

Doh. I'll get them in another pass.
Comment 6 WebKit Commit Bot 2013-12-16 11:20:12 PST 
Comment on attachment 219292 [details]
Patch

Clearing flags on attachment: 219292

Committed r160651: <http://trac.webkit.org/changeset/160651>
Comment 7 WebKit Commit Bot 2013-12-16 11:20:15 PST 
All reviewed patches have been landed.  Closing bug.