Bug 125750 - WebKit2 View Gestures: Pinching beyond the extremes doesn't animate back to the min/max
Summary: WebKit2 View Gestures: Pinching beyond the extremes doesn't animate back to t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
: 125751 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-12-14 20:11 PST by Tim Horton
Modified: 2013-12-16 18:25 PST (History)
4 users (show)

See Also:


Attachments
patch (15.81 KB, patch)
2013-12-15 04:53 PST, Tim Horton
no flags Details | Formatted Diff | Diff
patch (15.80 KB, patch)
2013-12-15 23:23 PST, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-12-14 20:11:22 PST
When you let go of a pinch where you exceeded the maximum or minimum scale, the view should animate back to the limit instead of snapping back.
Comment 1 Tim Horton 2013-12-15 04:53:41 PST
Created attachment 219276 [details]
patch

this may not apply because I have it on top of https://bugs.webkit.org/show_bug.cgi?id=125751 in my tree
Comment 2 Tim Horton 2013-12-15 04:54:18 PST
*** Bug 125751 has been marked as a duplicate of this bug. ***
Comment 3 Tim Horton 2013-12-15 23:23:06 PST
Created attachment 219297 [details]
patch
Comment 4 Simon Fraser (smfr) 2013-12-16 10:33:42 PST
Comment on attachment 219297 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219297&action=review

> Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:758
> +    // scrolling doesn't make the view jump; this is borrowed from ScrollableArea.

borrowed -> copied. Can we share code?