Bug 125745 - [iOS] Upstream changes to WebKit Public and Private headers
Summary: [iOS] Upstream changes to WebKit Public and Private headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-14 17:31 PST by Andy Estes
Modified: 2013-12-15 13:10 PST (History)
1 user (show)

See Also:

Attachments
[iOS] Upstream changes to WebKit Public and Private headers (97.75 KB, patch)
2013-12-14 17:34 PST, Andy Estes 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2013-12-14 17:31:40 PST 
[iOS] Upstream changes to WebKit Public and Private headers
Comment 1 Andy Estes 2013-12-14 17:34:48 PST 
Created attachment 219264 [details]
[iOS] Upstream changes to WebKit Public and Private headers
Comment 2 mitz 2013-12-14 17:52:27 PST 
Comment on attachment 219264 [details]
[iOS] Upstream changes to WebKit Public and Private headers

View in context: https://bugs.webkit.org/attachment.cgi?id=219264&action=review

> Source/WebKit/mac/Misc/WebLocalizableStrings.h:41
> +#if TARGET_OS_IPHONE
> +#if defined(__cplusplus)
> +extern "C" {
> +#endif        
> +#endif

Can this be done unconditionally?
Comment 3 Andy Estes 2013-12-14 18:12:45 PST 
(In reply to comment #2)
> (From update of attachment 219264 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219264&action=review
> 
> > Source/WebKit/mac/Misc/WebLocalizableStrings.h:41
> > +#if TARGET_OS_IPHONE
> > +#if defined(__cplusplus)
> > +extern "C" {
> > +#endif        
> > +#endif
> 
> Can this be done unconditionally?

Yes, I think so.

Thanks for the review!
Comment 4 Andy Estes 2013-12-14 18:14:39 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 219264 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=219264&action=review
> > 
> > > Source/WebKit/mac/Misc/WebLocalizableStrings.h:41
> > > +#if TARGET_OS_IPHONE
> > > +#if defined(__cplusplus)
> > > +extern "C" {
> > > +#endif        
> > > +#endif
> > 
> > Can this be done unconditionally?
> 
> Yes, I think so.
> 
> Thanks for the review!

Actually, it duplicates an unconditional extern "C" that already exists, so I'll just remove it.
Comment 5 Andy Estes 2013-12-15 13:10:57 PST 
Committed r160622: <http://trac.webkit.org/changeset/160622>