Bug 125745 – [iOS] Upstream changes to WebKit Public and Private headers

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[iOS] Upstream changes to WebKit Public and Private headers

[Andy Estes]

Created attachment 219264 [details]
[iOS] Upstream changes to WebKit Public and Private headers

Comment on attachment 219264 [details]
[iOS] Upstream changes to WebKit Public and Private headers

View in context: https://bugs.webkit.org/attachment.cgi?id=219264&action=review

> Source/WebKit/mac/Misc/WebLocalizableStrings.h:41
> +#if TARGET_OS_IPHONE
> +#if defined(__cplusplus)
> +extern "C" {
> +#endif        
> +#endif

Can this be done unconditionally?

[Andy Estes]

(In reply to comment #2)
> (From update of attachment 219264 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219264&action=review
> 
> > Source/WebKit/mac/Misc/WebLocalizableStrings.h:41
> > +#if TARGET_OS_IPHONE
> > +#if defined(__cplusplus)
> > +extern "C" {
> > +#endif        
> > +#endif
> 
> Can this be done unconditionally?

Yes, I think so.

Thanks for the review!

[Andy Estes]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 219264 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=219264&action=review
> > 
> > > Source/WebKit/mac/Misc/WebLocalizableStrings.h:41
> > > +#if TARGET_OS_IPHONE
> > > +#if defined(__cplusplus)
> > > +extern "C" {
> > > +#endif        
> > > +#endif
> > 
> > Can this be done unconditionally?
> 
> Yes, I think so.
> 
> Thanks for the review!

Actually, it duplicates an unconditional extern "C" that already exists, so I'll just remove it.

[Andy Estes]

Committed r160622: <http://trac.webkit.org/changeset/160622>