Page::theme() should return a reference.
Created attachment 219248 [details] Patch
Attachment 219248 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/html/HTMLFormControlElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLMeterElement.cpp', u'Source/WebCore/html/HTMLOptionElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/InputType.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/MediaControls.cpp', u'Source/WebCore/html/shadow/MediaControlsApple.cpp', u'Source/WebCore/html/shadow/MediaControlsGtk.cpp', u'Source/WebCore/html/shadow/MeterShadowElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/rendering/InlineTextBox.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderButton.cpp', u'Source/WebCore/rendering/RenderFileUploadControl.cpp', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderListBox.cpp', u'Source/WebCore/rendering/RenderMediaControlElements.cpp', u'Source/WebCore/rendering/RenderMenuList.cpp', u'Source/WebCore/rendering/RenderMeter.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderProgress.cpp', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControlSingleLine.cpp', u'Source/WebKit/efl/ewk/ewk_view.cpp', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit2/WebProcess/WebPage/efl/WebPageEfl.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/rendering/InlineTextBox.cpp:1288: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:1289: Wrong number of spaces before statement. (expected: 16) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:1480: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:1481: Wrong number of spaces before statement. (expected: 20) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:1480: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 5 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 219248 [details] Patch Attachment 219248 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/49408001
Comment on attachment 219248 [details] Patch Attachment 219248 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/46068040
Created attachment 219249 [details] Patch
Attachment 219249 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/html/HTMLFormControlElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLMeterElement.cpp', u'Source/WebCore/html/HTMLOptionElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/InputType.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/MediaControls.cpp', u'Source/WebCore/html/shadow/MediaControlsApple.cpp', u'Source/WebCore/html/shadow/MediaControlsGtk.cpp', u'Source/WebCore/html/shadow/MeterShadowElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/platform/efl/RenderThemeEfl.cpp', u'Source/WebCore/rendering/InlineTextBox.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderButton.cpp', u'Source/WebCore/rendering/RenderFileUploadControl.cpp', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderListBox.cpp', u'Source/WebCore/rendering/RenderMediaControlElements.cpp', u'Source/WebCore/rendering/RenderMenuList.cpp', u'Source/WebCore/rendering/RenderMeter.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderProgress.cpp', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControlSingleLine.cpp', u'Source/WebKit/efl/ewk/ewk_view.cpp', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit2/WebProcess/WebPage/efl/WebPageEfl.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/rendering/InlineTextBox.cpp:1288: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:1289: Wrong number of spaces before statement. (expected: 16) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:1480: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:1481: Wrong number of spaces before statement. (expected: 20) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:1480: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 5 in 41 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 219249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219249&action=review > Source/WebCore/page/Page.h:144 > - RenderTheme* theme() const { return m_theme.get(); } > + RenderTheme& theme() const { return *m_theme; } We might want to have separate const and non-const versions.
Created attachment 219250 [details] Land
Attachment 219250 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/html/HTMLFormControlElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLMeterElement.cpp', u'Source/WebCore/html/HTMLOptionElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/InputType.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/MediaControls.cpp', u'Source/WebCore/html/shadow/MediaControlsApple.cpp', u'Source/WebCore/html/shadow/MediaControlsGtk.cpp', u'Source/WebCore/html/shadow/MeterShadowElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/platform/efl/RenderThemeEfl.cpp', u'Source/WebCore/rendering/InlineTextBox.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderButton.cpp', u'Source/WebCore/rendering/RenderFileUploadControl.cpp', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderListBox.cpp', u'Source/WebCore/rendering/RenderMediaControlElements.cpp', u'Source/WebCore/rendering/RenderMenuList.cpp', u'Source/WebCore/rendering/RenderMeter.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderProgress.cpp', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControlSingleLine.cpp', u'Source/WebKit/efl/ewk/ewk_view.cpp', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit2/WebProcess/WebPage/efl/WebPageEfl.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/rendering/InlineTextBox.cpp:1289: Wrong number of spaces before statement. (expected: 16) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:1481: Wrong number of spaces before statement. (expected: 16) [whitespace/indent] [4] Total errors found: 2 in 41 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 219250 [details] Land Attachment 219250 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/49398025
Created attachment 219251 [details] Land pls
Comment on attachment 219251 [details] Land pls Attachment 219251 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/49348024
Comment on attachment 219251 [details] Land pls Clearing flags on attachment: 219251 Committed r160599: <http://trac.webkit.org/changeset/160599>
All reviewed patches have been landed. Closing bug.