Bug 125727 - FTL should know the actual frame size of LLVM generated code
Summary: FTL should know the actual frame size of LLVM generated code
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 113621
  Show dependency treegraph
 
Reported: 2013-12-13 20:42 PST by Filip Pizlo
Modified: 2017-04-24 19:12 PDT (History)
11 users (show)

See Also:


Attachments
Patch (1.37 KB, patch)
2015-09-04 09:37 PDT, Basile Clement
beidson: review-
beidson: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-12-13 20:42:03 PST
For now, we'll just guess that it's 1000 slots (slots = 8 bytes).
Comment 1 Filip Pizlo 2014-01-30 13:29:18 PST
This will just get fixed when we do the real stack check.

*** This bug has been marked as a duplicate of bug 125650 ***
Comment 2 Basile Clement 2015-09-03 18:49:52 PDT
DFGCommon::frameRegisterCount is still 1000.
Comment 3 Basile Clement 2015-09-04 09:37:23 PDT
Created attachment 260592 [details]
Patch
Comment 4 Brady Eidson 2017-04-24 19:09:34 PDT
Comment on attachment 260592 [details]
Patch

This patch has been pending review since 2015 with no recent activity.
It seems unlikely that it would even still apply to trunk in its current form.

Clearing from the review queue.

Feel free to update and resubmit if the patch is still relevant.