RESOLVED FIXED 125722
Small string improvements to JSInjectedScriptHost::type and other bindings
https://bugs.webkit.org/show_bug.cgi?id=125722
Summary Small string improvements to JSInjectedScriptHost::type and other bindings
Joseph Pecoraro
Reported 2013-12-13 19:55:25 PST
This function returns a few strings that JSC VM's always have ("string", "boolean", "number"). And other jsString(...) calls can use ASCIILiteral. NOTE: The paths that now return smallString are not used because InjectedScriptHost::type calls in InjectedScriptSource avoid calling type for primitives (at least right now).
Attachments
[PATCH] Proposed Fix (3.02 KB, patch)
2013-12-13 19:56 PST, Joseph Pecoraro
darin: review+
[PATCH] Incorporated Feedback (4.88 KB, patch)
2013-12-13 22:19 PST, Joseph Pecoraro
no flags
Joseph Pecoraro
Comment 1 2013-12-13 19:56:19 PST
Created attachment 219222 [details] [PATCH] Proposed Fix
Darin Adler
Comment 2 2013-12-13 20:24:25 PST
Comment on attachment 219222 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=219222&action=review > Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp:133 > + return jsString(exec, ASCIILiteral("array")); These should all be jsNontrivialString.
Joseph Pecoraro
Comment 3 2013-12-13 22:08:17 PST
(In reply to comment #2) > (From update of attachment 219222 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=219222&action=review > > > Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp:133 > > + return jsString(exec, ASCIILiteral("array")); > > These should all be jsNontrivialString. Oh cool!
Joseph Pecoraro
Comment 4 2013-12-13 22:19:23 PST
Created attachment 219238 [details] [PATCH] Incorporated Feedback This covers all the /jsString\(.*?"/ in Source/
WebKit Commit Bot
Comment 5 2013-12-14 09:49:55 PST
Comment on attachment 219238 [details] [PATCH] Incorporated Feedback Clearing flags on attachment: 219238 Committed r160597: <http://trac.webkit.org/changeset/160597>
WebKit Commit Bot
Comment 6 2013-12-14 09:49:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.