Bug 125722 – Small string improvements to JSInjectedScriptHost::type and other bindings

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Joseph Pecoraro]

This function returns a few strings that JSC VM's always have ("string", "boolean", "number"). And other jsString(...) calls can use ASCIILiteral.

NOTE: The paths that now return smallString are not used because InjectedScriptHost::type calls in InjectedScriptSource avoid calling type for primitives (at least right now).

[Joseph Pecoraro]

Created attachment 219222 [details]
[PATCH] Proposed Fix

[Darin Adler]

Comment on attachment 219222 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=219222&action=review

> Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp:133
> +        return jsString(exec, ASCIILiteral("array"));

These should all be jsNontrivialString.

[Joseph Pecoraro]

(In reply to comment #2)
> (From update of attachment 219222 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219222&action=review
> 
> > Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp:133
> > +        return jsString(exec, ASCIILiteral("array"));
> 
> These should all be jsNontrivialString.

Oh cool!

[Joseph Pecoraro]

Created attachment 219238 [details]
[PATCH] Incorporated Feedback

This covers all the /jsString\(.*?"/ in Source/

[WebKit Commit Bot]

Comment on attachment 219238 [details]
[PATCH] Incorporated Feedback

Clearing flags on attachment: 219238

Committed r160597: <http://trac.webkit.org/changeset/160597>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.