WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
125721
[Cocoa] Expose some layout milestones
https://bugs.webkit.org/show_bug.cgi?id=125721
Summary
[Cocoa] Expose some layout milestones
mitz
Reported
2013-12-13 19:04:14 PST
[Cocoa] Expose some layout milestones
Attachments
Add -browsingContextController:renderingProgressDidChange:
(5.74 KB, patch)
2013-12-13 19:09 PST
,
mitz
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
mitz
Comment 1
2013-12-13 19:09:28 PST
Created
attachment 219220
[details]
Add -browsingContextController:renderingProgressDidChange:
WebKit Commit Bot
Comment 2
2013-12-13 19:11:05 PST
Attachment 219220
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.h:39: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 3
2013-12-14 15:21:49 PST
Committed <
http://trac.webkit.org/r160602
>.
Simon Fraser (smfr)
Comment 4
2013-12-15 10:09:40 PST
This broke the 32-bit build:
http://build.webkit.org/builders/Apple%20MountainLion%20Release%20%2832-bit%20Build%29?numbuilds=100
mitz
Comment 5
2013-12-15 10:13:34 PST
(In reply to
comment #4
)
> This broke the 32-bit build: >
http://build.webkit.org/builders/Apple%20MountainLion%20Release%20%2832-bit%20Build%29?numbuilds=100
Attempted fix in <
http://trac.webkit.org/r160619
>.
mitz
Comment 6
2013-12-15 10:20:39 PST
More fixes coming up
mitz
Comment 7
2013-12-15 10:24:56 PST
TestWebKitAPI fix in <
http://trac.webkit.org/r160620
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug