Bug 125721 - [Cocoa] Expose some layout milestones
Summary: [Cocoa] Expose some layout milestones
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-13 19:04 PST by mitz
Modified: 2013-12-15 10:24 PST (History)
3 users (show)

See Also:


Attachments
Add -browsingContextController:renderingProgressDidChange: (5.74 KB, patch)
2013-12-13 19:09 PST, mitz
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2013-12-13 19:04:14 PST
[Cocoa] Expose some layout milestones
Comment 1 mitz 2013-12-13 19:09:28 PST
Created attachment 219220 [details]
Add -browsingContextController:renderingProgressDidChange:
Comment 2 WebKit Commit Bot 2013-12-13 19:11:05 PST
Attachment 219220 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.h:39:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2013-12-14 15:21:49 PST
Committed <http://trac.webkit.org/r160602>.
Comment 4 Simon Fraser (smfr) 2013-12-15 10:09:40 PST
This broke the 32-bit build:
http://build.webkit.org/builders/Apple%20MountainLion%20Release%20%2832-bit%20Build%29?numbuilds=100
Comment 5 mitz 2013-12-15 10:13:34 PST
(In reply to comment #4)
> This broke the 32-bit build:
> http://build.webkit.org/builders/Apple%20MountainLion%20Release%20%2832-bit%20Build%29?numbuilds=100

Attempted fix in <http://trac.webkit.org/r160619>.
Comment 6 mitz 2013-12-15 10:20:39 PST
More fixes coming up
Comment 7 mitz 2013-12-15 10:24:56 PST
TestWebKitAPI fix in <http://trac.webkit.org/r160620>.