Bug 125716 - [Mac] Cache partitioning asserts when associated NSURLRequest is nil
Summary: [Mac] Cache partitioning asserts when associated NSURLRequest is nil
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified OS X 10.9
: P2 Normal
Assignee: Vicki Pfau
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-12-13 15:59 PST by Vicki Pfau
Modified: 2013-12-16 15:28 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.61 KB, patch)
2013-12-13 16:03 PST, Vicki Pfau 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vicki Pfau 2013-12-13 15:59:47 PST 
In some cases, a ResourceRequest may attempt to update the cache partition when the associated NSURLRequest is nil. This will trigger an assertion.

<rdar://problem/15375976>
Comment 1 Vicki Pfau 2013-12-13 16:03:26 PST 
Created attachment 219207 [details]
Patch
Comment 2 Vicki Pfau 2013-12-16 14:38:51 PST 
Committed r160663: <http://trac.webkit.org/changeset/160663>
Comment 3 Alexey Proskuryakov 2013-12-16 15:26:09 PST 
Comment on attachment 219207 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219207&action=review

> Source/WebCore/platform/network/mac/ResourceRequestMac.mm:114
> +            m_cachePartition = cachePartition;

Does m_cachePartition need to be reset to null when m_nsRequest is null?
Comment 4 Vicki Pfau 2013-12-16 15:28:09 PST 
(In reply to comment #3)
> (From update of attachment 219207 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219207&action=review
> 
> > Source/WebCore/platform/network/mac/ResourceRequestMac.mm:114
> > +            m_cachePartition = cachePartition;
> 
> Does m_cachePartition need to be reset to null when m_nsRequest is null?

Since it doesn't reset m_cachePartition to null when the partition it gets out of the request is null either, I don't think this is necessary, but that might itself be a bug.